Xen devel - Oct 2009 - [PATCH] fix few small memory leaks in qemu

Hi all,
running qemu with valgrind I found few small memory leaks, this patch
fixes them.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

---

diff --git a/hw/vga.c b/hw/vga.c
index 90bd544..ccbcda9 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -2538,6 +2538,7 @@ void xen_vga_vram_map(uint64_t vram_addr, uint32_t
vga_ram_size)
 #ifdef CONFIG_STUBDOM
     xenfb_pv_display_vram(vram);
 #endif
+    free(pfn_list);
 }
 
 /* when used on xen environment, the vga_ram_base is not used */
diff --git a/xenstore.c b/xenstore.c
index da278f4..2133cea 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -709,7 +709,7 @@ static void xenstore_process_logdirty_event(void)
     act = xs_read(xsh, XBT_NULL, cmd_path, &len);
     if (!act) {
         fprintf(logfile, "Log-dirty: no command yet.\n");
-        return;
+        goto out;
     }
     fprintf(logfile, "Log-dirty command %s\n", act);
 
@@ -724,7 +724,11 @@ static void xenstore_process_logdirty_event(void)
 
     /* Ack that we''ve service the command */
     xs_write(xsh, XBT_NULL, ret_path, act, len);
+
     free(act);
+out:
+    free(ret_path);
+    free(cmd_path);
 }
 
 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefano Stabellini writes ("[Xen-devel] [PATCH] fix few small memory leaks
in qemu"):
> running qemu with valgrind I found few small memory leaks, this patch
> fixes them.
Well done.  I take it this is a candidate for a 3.4 backport.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel