Miroslav Rezanina
2009-Oct-19 11:57 UTC
Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
----- "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:> From: "Keir Fraser" <keir.fraser@eu.citrix.com> > To: "Miroslav Rezanina" <mrezanin@redhat.com> > Cc: xen-devel@lists.xensource.com, "Dexuan Cui" <dexuan.cui@intel.com> > Sent: Monday, October 19, 2009 1:43:49 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna > Subject: Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off > > On 19/10/2009 12:18, "Miroslav Rezanina" <mrezanin@redhat.com> wrote: > > >> I''ll be applying Dexuan''s original replacement patch. > >> > >> -- Keir > >> > > > > I retest version with removed NULL checks and in this case, my > system crashes. > > So there has to be checks for NULL or something else is wrong. > > Got a backtrace and Xen boot params? If you pass acpi=off, then > disable_acpi() is invoked, and this sets acpi_disabled. If > acpi_disabled=1, > then iommu_setup() sets iommu_enabled=0. If iommu_enabled=0 then I > think all > the update_ire_from_* and similar hooks get disabled in the callers. > So > something unexpected must be happening. > > -- Keir > >Unfortunately, machine I''m working on has no serial output enabled. I try to reproduce this on a machine where I can get log. I try xen-3.4-testing c/s 19785: 7e2169ea6687 (that is eqaul to xen-unstable c/s 20338: 5f28661bb2bb. Without checks - machine crashes during boot (when trying to init eth2) with checks - machine boots successfully. ---- Grub conf: kernel /xen-3.4.2-rc1-pre.gz acpi=off iommu=1 module /vmlinuz-2.6.18.8 ro root=LABEL=/ rhgb module /initrd-2.6.18.8.img -- Miroslav Rezanina Software Engineer - Virtualization Team - XEN kernel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Cui, Dexuan
2009-Oct-19 14:01 UTC
RE: [Xen-devel] RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in msi_msg_read_remap_rte with acpi=off
Miroslav Rezanina wrote:> ----- "Keir Fraser" <keir.fraser@eu.citrix.com> wrote: > >> From: "Keir Fraser" <keir.fraser@eu.citrix.com> >> To: "Miroslav Rezanina" <mrezanin@redhat.com> >> Cc: xen-devel@lists.xensource.com, "Dexuan Cui" >> <dexuan.cui@intel.com> >> Sent: Monday, October 19, 2009 1:43:49 PM GMT +01:00 Amsterdam / >> Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: [Xen-devel] >> RE: [Xen-changelog] [xen-unstable]vt-d: Fixpanic in >> msi_msg_read_remap_rte with acpi=off >> >> On 19/10/2009 12:18, "Miroslav Rezanina" <mrezanin@redhat.com> wrote: >> >>>> I'll be applying Dexuan's original replacement patch. >>>> >>>> -- Keir >>>> >>> >>> I retest version with removed NULL checks and in this case, my >>> system crashes. So there has to be checks for NULL or something >>> else is wrong. >> >> Got a backtrace and Xen boot params? If you pass acpi=off, then >> disable_acpi() is invoked, and this sets acpi_disabled. If >> acpi_disabled=1, >> then iommu_setup() sets iommu_enabled=0. If iommu_enabled=0 then I >> think all >> the update_ire_from_* and similar hooks get disabled in the callers. >> So >> something unexpected must be happening. >> >> -- Keir >> >> > Unfortunately, machine I'm working on has no serial output enabled. I > try to reproduce this on a machine where I can get log. I try > xen-3.4-testing c/s 19785: 7e2169ea6687 (that is eqaul to > xen-unstable c/s 20338: 5f28661bb2bb. Without checks - machine > crashes during boot (when trying to init eth2) > with checks - machine boots successfully. > ---- > Grub conf: > kernel /xen-3.4.2-rc1-pre.gz acpi=off iommu=1 > module /vmlinuz-2.6.18.8 ro root=LABEL=/ rhgb > module /initrd-2.6.18.8.imgStrange... Looks before iommu_setup(), no IOAPIC IRTE read/write and msi msg read/write would occur. Hi Miroslav, can you attach your serial log of the crash when you use xen-3.4-testing 19785? It's interesting to me. :-) -- Dexuan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel