I wasn''t able to easily test the check_tsc_warp patch on a machine which did have skew, so I synthesized skew and discovered this bug. Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com> diff -r f9cbb5a274d6 xen/arch/x86/time.c --- a/xen/arch/x86/time.c Wed Oct 07 10:26:39 2009 +0100 +++ b/xen/arch/x86/time.c Wed Oct 07 14:40:02 2009 -0600 @@ -1494,7 +1494,7 @@ void check_tsc_warp(unsigned long tsc_kh if ( unlikely(prev > now) ) { spin_lock(&sync_lock); - if ( *max_warp > prev - now ) + if ( *max_warp < prev - now ) *max_warp = prev - now; spin_unlock(&sync_lock); } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel