Xen devel - Oct 2009 - Re: [Xen-changelog] [xen-unstable] Introduce a grant_entry_v2 structure.

Xen patchbot-unstable wrote:
> # HG changeset patch
> # User Keir Fraser <keir.fraser@citrix.com>
> # Date 1254897996 -3600
> # Node ID 95ea2052b41b209fa913d6861143915140be4171
> # Parent  7d4f05a65d5a840eca5fdf1319c696d5583f100d
> Introduce a grant_entry_v2 structure.
> 
> Signed-off-by: Steven Smith <steven.smith@citrix.com>
This patch breaks my build:

make[3]: Entering directory `/home/gross/xen-unstable.hg/tools/libxc''
gcc  -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value
-Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD -MF .xc_core.o.d
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE
-I../../xen/common/libelf -Werror -Wmissing-prototypes  -I. -I../xenstore
-I../include -c -o xc_core.o xc_core.c
In file included from xg_private.h:14,
                 from xc_core.c:52:
xenctrl.h:948: error: ‘grant_entry_v2’ defined as wrong kind of tag
make[3]: *** [xc_core.o] Error 1
make[3]: Leaving directory `/home/gross/xen-unstable.hg/tools/libxc''
make[2]: *** [build] Error 2
make[2]: Leaving directory `/home/gross/xen-unstable.hg/tools/libxc''
make[1]: *** [subdir-all-libxc] Error 2
make[1]: Leaving directory `/home/gross/xen-unstable.hg/tools''
make: *** [subdirs-all] Error 2


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 636 47950
Fujitsu Technolgy Solutions               e-mail: juergen.gross@ts.fujitsu.com
Otto-Hahn-Ring 6                        Internet: ts.fujitsu.com
D-81739 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 07/10/2009 10:01, "Juergen Gross"
<juergen.gross@ts.fujitsu.com> wrote:
>> Introduce a grant_entry_v2 structure.
>> 
>> Signed-off-by: Steven Smith <steven.smith@citrix.com>
> 
> This patch breaks my build:
Should be fixed by c/s 20288.

 Thanks,
 K.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Keir Fraser wrote:
> On 07/10/2009 10:01, "Juergen Gross"
<juergen.gross@ts.fujitsu.com> wrote:
> 
>>> Introduce a grant_entry_v2 structure.
>>>
>>> Signed-off-by: Steven Smith <steven.smith@citrix.com>
>> This patch breaks my build:
> 
> Should be fixed by c/s 20288.
Build still not okay:

cc1: warnings being treated as errors
xc_minios.c:417: error: no previous prototype for ‘xc_gnttab_map_table’
make[4]: *** [xc_minios.o] Error 1
make[4]: Leaving directory
`/home/gross/xen-unstable.hg/stubdom/libxc-x86_64''
make[3]: *** [build] Error 2
make[3]: Leaving directory
`/home/gross/xen-unstable.hg/stubdom/libxc-x86_64''
make[2]: *** [libxc-x86_64/libxenctrl.a] Error 2
make[2]: Leaving directory `/home/gross/xen-unstable.hg/stubdom''
make[1]: *** [install-stubdom] Error 2
make[1]: Leaving directory `/home/gross/xen-unstable.hg''
make: *** [world] Error 2


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 636 47950
Fujitsu Technolgy Solutions               e-mail: juergen.gross@ts.fujitsu.com
Otto-Hahn-Ring 6                        Internet: ts.fujitsu.com
D-81739 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 07/10/2009 12:26, "Juergen Gross"
<juergen.gross@ts.fujitsu.com> wrote:
> Keir Fraser wrote:
>> On 07/10/2009 10:01, "Juergen Gross"
<juergen.gross@ts.fujitsu.com> wrote:
>> 
>>>> Introduce a grant_entry_v2 structure.
>>>> 
>>>> Signed-off-by: Steven Smith <steven.smith@citrix.com>
>>> This patch breaks my build:
>> 
>> Should be fixed by c/s 20288.
> 
> Build still not okay:
Fixed by c/s 20291.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> >>>> Introduce a grant_entry_v2 structure.
> >>>> 
> >>>> Signed-off-by: Steven Smith
<steven.smith@citrix.com>
> >>> This patch breaks my build:
> >> 
> >> Should be fixed by c/s 20288.
> > 
> > Build still not okay:
> Fixed by c/s 20291.
Oops; sorry about that.  I completely forgot about the non-Linux dom0
OSes.

Steven.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 07/10/2009 18:55, "Steven Smith" <Steven.Smith@eu.citrix.com>
wrote:
>>>>>> Introduce a grant_entry_v2 structure.
>>>>>> 
>>>>>> Signed-off-by: Steven Smith
<steven.smith@citrix.com>
>>>>> This patch breaks my build:
>>>> 
>>>> Should be fixed by c/s 20288.
>>> 
>>> Build still not okay:
>> Fixed by c/s 20291.
> Oops; sorry about that.  I completely forgot about the non-Linux dom0
> OSes.
Could you have a stab at fixing the IA64 gnttab hooks? Either that or
solicit help from the ia64 devs (cc''ing Isaku).

 K.

grant_table.c: In function ''gnttab_populate_status_frames'':
grant_table.c:1026: warning: implicit declaration of function
''gnttab_create_status_page''
grant_table.c: In function ''gnttab_grow_table'':
grant_table.c:1088: error: ''struct grant_table'' has no member
named ''shared''
grant_table.c:1088: error: ''struct grant_table'' has no member
named ''shared''
grant_table.c: In function ''__acquire_grant_for_copy'':
grant_table.c:1757: error: ''INVALID_GFN'' undeclared (first use
in this
function)
grant_table.c:1757: error: (Each undeclared identifier is reported only once
grant_table.c:1757: error: for each function it appears in.)
grant_table.c: In function ''gnttab_get_status_frames'':
grant_table.c:2083: warning: implicit declaration of function
''gnttab_status_gmfn''
grant_table.c: In function ''grant_table_create'':
grant_table.c:2326: error: ''struct grant_table'' has no member
named ''shared''
grant_table.c:2326: error: ''struct grant_table'' has no member
named ''shared''



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> >>>>>> Introduce a grant_entry_v2 structure.
> >>>>>> 
> >>>>>> Signed-off-by: Steven Smith
<steven.smith@citrix.com>
> >>>>> This patch breaks my build:
> >>>> 
> >>>> Should be fixed by c/s 20288.
> >>> 
> >>> Build still not okay:
> >> Fixed by c/s 20291.
> > Oops; sorry about that.  I completely forgot about the non-Linux dom0
> > OSes.
> Could you have a stab at fixing the IA64 gnttab hooks? Either that or
> solicit help from the ia64 devs (cc''ing Isaku).
I don''t have an IA64 build environment set up right now.  Do you know
if there are any Citrix (or other) ones which I could borrow for a
bit, please?

Steven.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 08/10/2009 13:01, "Steven Smith" <Steven.Smith@eu.citrix.com>
wrote:
>>> Oops; sorry about that.  I completely forgot about the non-Linux
dom0
>>> OSes.
>> Could you have a stab at fixing the IA64 gnttab hooks? Either that or
>> solicit help from the ia64 devs (cc''ing Isaku).
> I don''t have an IA64 build environment set up right now.  Do you
know
> if there are any Citrix (or other) ones which I could borrow for a
> bit, please?
We usually just take a stab and let the ia64 guys fix up if necessary. :-) I
suggest just run a draft patch by Isaku.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

I''ll look into it tomorrow or next week.
thanks,

On Thu, Oct 08, 2009 at 11:58:18AM +0100, Keir Fraser
wrote:
> On 07/10/2009 18:55, "Steven Smith"
<Steven.Smith@eu.citrix.com> wrote:
> 
> >>>>>> Introduce a grant_entry_v2 structure.
> >>>>>> 
> >>>>>> Signed-off-by: Steven Smith
<steven.smith@citrix.com>
> >>>>> This patch breaks my build:
> >>>> 
> >>>> Should be fixed by c/s 20288.
> >>> 
> >>> Build still not okay:
> >> Fixed by c/s 20291.
> > Oops; sorry about that.  I completely forgot about the non-Linux dom0
> > OSes.
> 
> Could you have a stab at fixing the IA64 gnttab hooks? Either that or
> solicit help from the ia64 devs (cc''ing Isaku).
> 
>  K.
> 
> grant_table.c: In function
''gnttab_populate_status_frames'':
> grant_table.c:1026: warning: implicit declaration of function
> ''gnttab_create_status_page''
> grant_table.c: In function ''gnttab_grow_table'':
> grant_table.c:1088: error: ''struct grant_table'' has no
member named ''shared''
> grant_table.c:1088: error: ''struct grant_table'' has no
member named ''shared''
> grant_table.c: In function ''__acquire_grant_for_copy'':
> grant_table.c:1757: error: ''INVALID_GFN'' undeclared
(first use in this
> function)
> grant_table.c:1757: error: (Each undeclared identifier is reported only
once
> grant_table.c:1757: error: for each function it appears in.)
> grant_table.c: In function ''gnttab_get_status_frames'':
> grant_table.c:2083: warning: implicit declaration of function
> ''gnttab_status_gmfn''
> grant_table.c: In function ''grant_table_create'':
> grant_table.c:2326: error: ''struct grant_table'' has no
member named ''shared''
> grant_table.c:2326: error: ''struct grant_table'' has no
member named ''shared''
> 
> 
-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> > >>>>>> Introduce a grant_entry_v2 structure.
> > >>>>>> 
> > >>>>>> Signed-off-by: Steven Smith
<steven.smith@citrix.com>
> > >>>>> This patch breaks my build:
> > >>>> 
> > >>>> Should be fixed by c/s 20288.
> > >>> 
> > >>> Build still not okay:
> > >> Fixed by c/s 20291.
> > > Oops; sorry about that.  I completely forgot about the non-Linux
dom0
> > > OSes.
> > Could you have a stab at fixing the IA64 gnttab hooks? Either that or
> > solicit help from the ia64 devs (cc''ing Isaku).
> I don''t have an IA64 build environment set up right now.  Do you
know
> if there are any Citrix (or other) ones which I could borrow for a
> bit, please?
After some fiddling, I managed to get an IA64 cross toolchain set up,
and the attached patch fixes the IA64 build of the hypervisor.  I
don''t have any IA64 test boxes, so I''ve no idea whether it
actually
works, but it does build.

I''ve not looked at the changes to libxc, because my cross-compiler
doesn''t seem to be able to cope with userspace stuff, but I''d
guess
they''ll probably be okay.

Sorry about the mess.

Steven.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel