Xen devel - Oct 2009 - [PATCH 0 of 8] Xen-side netchannel2 patches, take two

This patch series includes all of the Xen and tools bits of
netchannel2.  It''s essentially similar to the one I posted on Sunday,
except:

-- I''ve dropped the unmodified drivers support.  It''d probably
be
   fairly straightforward to re-introduce it, but it''s not clear that
   anyone''s actually using unmodified drivers any more (they
don''t
   even build against a 2.6.27 kernel, for instance).

-- I''ve switched to using uint64_t for page numbers in the public
   structures, because uint32_t is no longer enough now that Xen
   supports sparse physical memory.

-- The gnttab_get_status_frames structure now uses a
   GUEST_HANDLE(uint64_t) for the pointer to the status frames array,
   rather than a straight uint64_t.

The problems which these changes fix were all pointed out by Jan
Beulich (thanks!).

Most of these patches are unchanged since last time, but I''m reposting
all of them just to keep everything together.  The only one with
substantial changes is number 5:

changeset:   20275:842baf721920
tag:         introduce-grant_entry_v2
user:        Steven Smith <steven.smith@eu.citrix.com>
date:        Mon Sep 22 12:23:28 2008 +0100
files:       tools/libxc/xc_linux.c tools/libxc/xc_offline_page.c
tools/libxc/xenctrl.h xen/arch/x86/hvm/hvm.c xen/arch/x86/mm.c
xen/common/compat/grant_table.c xen/common/grant_table.c xen/include/Makefile
xen/include/asm-x86/grant_table.h xen/include/public/grant_table.h
xen/include/public/memory.h xen/include/public/xen.h
xen/include/xen/grant_table.h xen/include/xlat.lst
description:
Introduce a grant_entry_v2 structure.

Signed-off-by: Steven Smith <steven.smith@citrix.com>


There are also minor changes to the next two patches, mostly just
compensating for renamed fields in structures.



I''ve also fixed up the Linux patch queues to match the new interface,
but won''t be posting the new queues, because they''re rather
large and
have no substantial changes from last time.  Instead, I''ve pushed the
changed queues to the git repos:

git://xenbits.xensource.com/people/ssmith/nc2-2.6.27.git branch
pq_for_merge (for the XCI 2.6.27 tree)

git://xenbits.xensource.com/people/ssmith/netchannel2-pvops.git branch
nc2/fixed_v2_grant_table_interface (for the upstream git tree)


If people would prefer I repost the whole series then I can do that as
well.


I think this should cover all of the review comments; please shout at
me if I''ve missed anything.

Steven.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, Oct 06, 2009 at 04:35:42PM +0100, steven.smith@citrix.com
wrote:
> This patch series includes all of the Xen and tools bits of
> netchannel2.  It''s essentially similar to the one I posted on
Sunday,
> except:
> 
> -- I''ve dropped the unmodified drivers support.  It''d
probably be
>    fairly straightforward to re-introduce it, but it''s not clear
that
>    anyone''s actually using unmodified drivers any more (they
don''t
>    even build against a 2.6.27 kernel, for instance).
At least Redhat/Fedora guys have been thinking of shipping pv-on-hvm Xen
drivers for Fedora 12 / RHEL6.. But I don''t know what''s the
status of that.

There''s also a note about it on Xen Wiki:
http://wiki.xensource.com/xenwiki/XenParavirtOps

"Work in progress: pv-on-hvm driver support "

dunno about the status of that either :)

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> On Tue, Oct 06, 2009 at 04:35:42PM +0100, steven.smith@citrix.com wrote:
> > This patch series includes all of the Xen and tools bits of
> > netchannel2.  It''s essentially similar to the one I posted on
Sunday,
> > except:
> >
> > -- I''ve dropped the unmodified drivers support. 
It''d probably be
> >    fairly straightforward to re-introduce it, but it''s not
clear that
> >    anyone''s actually using unmodified drivers any more (they
don''t
> >    even build against a 2.6.27 kernel, for instance).
> 
> At least Redhat/Fedora guys have been thinking of shipping pv-on-hvm Xen
> drivers for Fedora 12 / RHEL6.. But I don''t know what''s
the status of
> that.
Yes, this certainly isn''t a feature we want to drop. In fact, it would
be good to see the pv-on-hvm drivers modified to use some of the pvops functions
where available.

Ian

 
> There''s also a note about it on Xen Wiki:
> http://wiki.xensource.com/xenwiki/XenParavirtOps
> 
> "Work in progress: pv-on-hvm driver support "
> 
> dunno about the status of that either :)
> 
> -- Pasi
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 10/06/09 13:41, Ian Pratt wrote:
>> On Tue, Oct 06, 2009 at 04:35:42PM +0100, steven.smith@citrix.com
wrote:
>>     
>>> This patch series includes all of the Xen and tools bits of
>>> netchannel2.  It''s essentially similar to the one I posted
on Sunday,
>>> except:
>>>
>>> -- I''ve dropped the unmodified drivers support. 
It''d probably be
>>>    fairly straightforward to re-introduce it, but it''s not
clear that
>>>    anyone''s actually using unmodified drivers any more
(they don''t
>>>    even build against a 2.6.27 kernel, for instance).
>>>       
>> At least Redhat/Fedora guys have been thinking of shipping pv-on-hvm
Xen
>> drivers for Fedora 12 / RHEL6.. But I don''t know
what''s the status of
>> that.
>>     
> Yes, this certainly isn''t a feature we want to drop. In fact, it
would be good to see the pv-on-hvm drivers modified to use some of the pvops
functions where available.
>   
Don Dutile from RH is actively working on this.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

This should be applied against the linux repository.

Patch 20267:e9366bed077e modified the definition of sring in the xen 
repo''s version of ring.h, but not the version in the linux kernel repo.
That change broke pause/resume/shutdown messages from the blktap2 kernel 
module, which (for the time being) relies on pad[0] being at consistent 
location in the sring struct.  This patch fixes this regression by 
resyncronizing the two the files.

Signed off by: Jake Wires <Jake.Wires@citrix.com>

--Dutch

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> > > This patch series includes all of the Xen and tools bits of
> > > netchannel2.  It''s essentially similar to the one I
posted on Sunday,
> > > except:
> > >
> > > -- I''ve dropped the unmodified drivers support. 
It''d probably be
> > >    fairly straightforward to re-introduce it, but it''s
not clear that
> > >    anyone''s actually using unmodified drivers any more
(they don''t
> > >    even build against a 2.6.27 kernel, for instance).
> > 
> > At least Redhat/Fedora guys have been thinking of shipping pv-on-hvm
Xen
> > drivers for Fedora 12 / RHEL6.. But I don''t know
what''s the status of
> > that.
> Yes, this certainly isn''t a feature we want to drop. In fact, it
> would be good to see the pv-on-hvm drivers modified to use some of
> the pvops functions where available.
Okay.  If this is something which we want to keep working in the
future then it might be a good idea to sanify the build system a bit.
The current approach is an unholy mixture of 2.6.18, the host kernel,
and whatever kernel you''re grabbing the actual drivers from, and is
basically just asking for trouble.

Steven.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, Oct 07, 2009 at 08:21:08PM +0100, Steven Smith
wrote:
> > > > This patch series includes all of the Xen and tools bits of
> > > > netchannel2.  It''s essentially similar to the one I
posted on Sunday,
> > > > except:
> > > >
> > > > -- I''ve dropped the unmodified drivers support. 
It''d probably be
> > > >    fairly straightforward to re-introduce it, but
it''s not clear that
> > > >    anyone''s actually using unmodified drivers any
more (they don''t
> > > >    even build against a 2.6.27 kernel, for instance).
> > > 
> > > At least Redhat/Fedora guys have been thinking of shipping
pv-on-hvm Xen
> > > drivers for Fedora 12 / RHEL6.. But I don''t know
what''s the status of
> > > that.
> > Yes, this certainly isn''t a feature we want to drop. In fact,
it
> > would be good to see the pv-on-hvm drivers modified to use some of
> > the pvops functions where available.
> Okay.  If this is something which we want to keep working in the
> future then it might be a good idea to sanify the build system a bit.
> The current approach is an unholy mixture of 2.6.18, the host kernel,
> and whatever kernel you''re grabbing the actual drivers from, and
is
> basically just asking for trouble.
> 
Hmm.. Did Novell guys port/fix the unmodified drivers to SLES11 (2.6.27) ?

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> Pasi Kärkkäinen<pasik@iki.fi> 08.10.09 10:07 >>>
>Hmm.. Did Novell guys port/fix the unmodified drivers to SLES11 (2.6.27) ?
Yes. They''re building for us without extra patches afaict (I think we
do
need some adjustment on even newer kernels, due to the movement
of the arch include directories, but that should be an upstreamable
patch - not sure why it didn''t get submitted). Of course the whole
thing
gets more complicated if you want to also consider a pv-ops-Xen-enabled
kernel config, but otoh I recall Jeremy stating now and then that he
would be working on pv driver building on pure pv-ops kernel sources.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel