Kouya Shimura
2009-Sep-18 05:24 UTC
[Xen-devel] [PATCH] x86 hvm: fix missing ticks bug of c/s 20218
With c/s 20218, timer ticks might be missed when IRQs of a timer are queued. Next scheduled time is accumulated wrongly. Thanks to Christoph for the report. Thanks, Kouya Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> Reported-by: Christoph Egger <Christoph.Egger@amd.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Sep-18 07:51 UTC
[Xen-devel] Re: [PATCH] x86 hvm: fix missing ticks bug of c/s 20218
Moving the line ''pt->scheduled += pt->period'' inside the if statement looks pretty dubious. Does your fix still work if we don''t move that line? For the default timer mode I''m not sure it should make any difference either way, but it would for timer mode 0. -- Keir On 18/09/2009 06:24, "Kouya Shimura" <kouya@jp.fujitsu.com> wrote:> With c/s 20218, timer ticks might be missed when IRQs of a timer are queued. > Next scheduled time is accumulated wrongly. > > Thanks to Christoph for the report. > > Thanks, > Kouya > > Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> > Reported-by: Christoph Egger <Christoph.Egger@amd.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kouya Shimura
2009-Sep-18 08:33 UTC
[Xen-devel] Re: [PATCH] x86 hvm: fix missing ticks bug of c/s 20218
Keir Fraser writes:> Moving the line ''pt->scheduled += pt->period'' inside the if statement looks > pretty dubious. Does your fix still work if we don''t move that line? For the > default timer mode I''m not sure it should make any difference either way, > but it would for timer mode 0.Oops, my brain was dead. You are right. New one is attached. Of course it works. Thanks, Kouya> > -- Keir > > On 18/09/2009 06:24, "Kouya Shimura" <kouya@jp.fujitsu.com> wrote: > > > With c/s 20218, timer ticks might be missed when IRQs of a timer are queued. > > Next scheduled time is accumulated wrongly. > > > > Thanks to Christoph for the report. > > > > Thanks, > > Kouya > > > > Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> > > Reported-by: Christoph Egger <Christoph.Egger@amd.com> > > >Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> Reported-by: Christoph Egger <Christoph.Egger@amd.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel