Masaki Kanno
2009-Sep-17 07:32 UTC
[Xen-devel] [PATCH] xend: Unlink VDI instances and VBD instances
Hi, When VBD instances are destroyed by xm delete command, VDI instances keep linking to the VBD instances unilaterally. This patch eliminates the unilateral linking. Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Best regards, Kan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Sep-18 13:43 UTC
Re: [Xen-devel] [PATCH] xend: Unlink VDI instances and VBD instances
Applied as c/s 20221, but it produces the following backtrace, so I reverted
it:
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/xen/xend/XendCheckpoint.py",
line
165, in save
dominfo.destroy()
File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py",
line
2855, in destroy
XendDomain.instance().remove_domain(self)
File "/usr/lib/python2.4/site-packages/xen/xend/XendDomain.py", line
468,
in remove_domain
self._remove_domain(info, domid)
File "/usr/lib/python2.4/site-packages/xen/xend/XendDomain.py", line
489,
in _remove_domain
info.unlink_xapi_instances()
File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py",
line
4054, in unlink_xapi_instances
vdi = XendNode.instance().get_vdi_by_uuid(dev_info[''VDI''])
KeyError: ''VDI''
-- Keir
On 17/09/2009 08:32, "Masaki Kanno"
<kanno.masaki@jp.fujitsu.com> wrote:
> Hi,
>
> When VBD instances are destroyed by xm delete command, VDI instances
> keep linking to the VBD instances unilaterally.
> This patch eliminates the unilateral linking.
>
> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
>
> Best regards,
> Kan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Masaki Kanno
2009-Sep-24 01:32 UTC
Re: [Xen-devel] [PATCH] xend: Unlink VDI instances and VBD instances
Hi Keir, Sorry. I didn''t test the patch on a server to which XenAPI mode was invalid. I will send a new patch. Best regards, Kan Fri, 18 Sep 2009 14:43:55 +0100, Keir Fraser wrote:>Applied as c/s 20221, but it produces the following backtrace, so I reverted >it: >Traceback (most recent call last): > File "/usr/lib/python2.4/site-packages/xen/xend/XendCheckpoint.py", line >165, in save > dominfo.destroy() > File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py", line >2855, in destroy > XendDomain.instance().remove_domain(self) > File "/usr/lib/python2.4/site-packages/xen/xend/XendDomain.py", line 468, >in remove_domain > self._remove_domain(info, domid) > File "/usr/lib/python2.4/site-packages/xen/xend/XendDomain.py", line 489, >in _remove_domain > info.unlink_xapi_instances() > File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py", line >4054, in unlink_xapi_instances > vdi = XendNode.instance().get_vdi_by_uuid(dev_info[''VDI'']) >KeyError: ''VDI'' > > -- Keir > > >On 17/09/2009 08:32, "Masaki Kanno" <kanno.masaki@jp.fujitsu.com> wrote: > >> Hi, >> >> When VBD instances are destroyed by xm delete command, VDI instances >> keep linking to the VBD instances unilaterally. >> This patch eliminates the unilateral linking. >> >> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> >> >> Best regards, >> Kan >> > > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2009-Sep-24 08:20 UTC
[Xen-devel] [PATCH v2] xend: Unlink VDI instances and VBD instances
Hi Keir, VBD information in xend does not have a VDI value if XenAPI mode is invalid. A new patch confirms the VDI value is valid. So, the new patch cuts off VDI->VBD links if the VDI value is valid. Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Best regards, Kan Thu, 24 Sep 2009 10:32:33 +0900, Masaki Kanno wrote:>Hi Keir, > >Sorry. I didn''t test the patch on a server to which XenAPI mode was >invalid. I will send a new patch. > >Best regards, > Kan > >Fri, 18 Sep 2009 14:43:55 +0100, Keir Fraser wrote: > >>Applied as c/s 20221, but it produces the following backtrace, so I reverted >>it: >>Traceback (most recent call last): >> File "/usr/lib/python2.4/site-packages/xen/xend/XendCheckpoint.py", line >>165, in save >> dominfo.destroy() >> File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py", line >>2855, in destroy >> XendDomain.instance().remove_domain(self) >> File "/usr/lib/python2.4/site-packages/xen/xend/XendDomain.py", line 468, >>in remove_domain >> self._remove_domain(info, domid) >> File "/usr/lib/python2.4/site-packages/xen/xend/XendDomain.py", line 489, >>in _remove_domain >> info.unlink_xapi_instances() >> File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py", line >>4054, in unlink_xapi_instances >> vdi = XendNode.instance().get_vdi_by_uuid(dev_info[''VDI'']) >>KeyError: ''VDI'' >> >> -- Keir >> >> >>On 17/09/2009 08:32, "Masaki Kanno" <kanno.masaki@jp.fujitsu.com> wrote: >> >>> Hi, >>> >>> When VBD instances are destroyed by xm delete command, VDI instances >>> keep linking to the VBD instances unilaterally. >>> This patch eliminates the unilateral linking. >>> >>> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> >>> >>> Best regards, >>> Kan >>> >> >> >> >>_______________________________________________ >>Xen-devel mailing list >>Xen-devel@lists.xensource.com >>http://lists.xensource.com/xen-devel > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel