Xen devel - Sep 2009 - drbd patch breaks pygrub booting

Changeset 20158:f9ce5858 introduces some new code around line 3002 in
XendDomainInfo.py which refers to a variable `disktype'' which is not
set at all.

As a consequence, no pygrub-based domain will boot any more.  An
example stacktrace from xend.log is below.  I think, but I''m not sure,
that `disktype'' here should read `devtype''.

Ian.

[2009-09-09 10:47:35 4579] ERROR (xmlrpclib2:178) Internal error handling
xend.domain.create
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/xen/util/xmlrpclib2.py", line
131, in _marshaled_dispatch
    response = self._dispatch(method, params)
  File "/usr/lib/python2.4/SimpleXMLRPCServer.py", line 406, in
_dispatch
    return func(*params)
  File
"/usr/lib/python2.4/site-packages/xen/xend/server/XMLRPCServer.py",
line 79, in domain_create
    info = XendDomain.instance().domain_create(config)
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomain.py", line
970, in domain_create
    dominfo = XendDomainInfo.create(config)
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py",
line 102, in create
    vm.start()
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py",
line 453, in start
    XendTask.log_progress(31, 60, self._initDomain)
  File "/usr/lib/python2.4/site-packages/xen/xend/XendTask.py", line
209, in log_progress
    retval = func(*args, **kwds)
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py",
line 2599, in _initDomain
    self._configureBootloader()
  File "/usr/lib/python2.4/site-packages/xen/xend/XendDomainInfo.py",
line 3002, in _configureBootloader
    if disktype.find(":") != -1:
UnboundLocalError: local variable ''disktype'' referenced before
assignment

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 09/09/2009 12:04, "Ian Jackson" <Ian.Jackson@eu.citrix.com>
wrote:
> Changeset 20158:f9ce5858 introduces some new code around line 3002 in
> XendDomainInfo.py which refers to a variable `disktype'' which is
not
> set at all.
> 
> As a consequence, no pygrub-based domain will boot any more.  An
> example stacktrace from xend.log is below.  I think, but I''m not
sure,
> that `disktype'' here should read `devtype''.
Argh, that''s me editing the patch before checkin, and screwing it up. I
think it should be ''disk.find(":")'' -- would that
work okay for you?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Last messages been sent to console :-

ohci 1394: fw-host :OHCI-1394 (PCI) IRQ=[19] MMIO=[febfb000-febfb7ff]
Max Packet = [2048] IR/IT contexts [8/8]
udevadm [976]: error sending message connection refused.

Booting up hangs.
Grub entry is the same which works for F11,F12
Kernel 2.6.31-rc6 loads fine under the same Xen Hypervisor.

Boris.
P.S.
Sorry, boxes had been placed again on theirs places ( 20m distance)





      

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel