Michal Novotny
2009-Aug-20 15:02 UTC
[Xen-devel] [PATCH] Add password support to pygrub for GRUB bootloader
Hi, this is the patch to add password support to pygrub for GRUB bootloader. It basically checks for the presence of password line in grub.conf of the guest image and if this line is present, it supports both clear text and md5 versions of the password. Editing the grub entries and command-line are disabled when some password is set in domain''s grub.conf file but the password was not entered yet. Also, new option to press ''p'' in interactive pygrub has been added to allow entering the grub password. It''s been tested on x86_64 with PV guests and was working fine. Also, the countdown has been stopped after key was pressed, ie. the user is probably editing the boot configuration. Michal Signed-off-by: Michal Novotny <minovotn@redhat.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Michal Novotny
2009-Aug-21 10:18 UTC
Re: [Xen-devel] [PATCH] Add password support to pygrub for GRUB bootloader
Hi, this patch (applied as http://xenbits.xensource.com/xen-unstable.hg?rev/8f783adc0ee3 , c/s 20099) introduced a problem for Itanium systems using LiloConf. This patch is the fix for elilo. Since I am unable to find information whether eLilo supports password protection or not, this patch makes the entry and command-line editing on IA64 systems as if no patch with c/s 20099 was applied. Thanks, Michal Michal Novotny wrote:> Hi, > this is the patch to add password support to pygrub for GRUB > bootloader. It basically checks for the presence of password line in > grub.conf of the guest image and if this line is present, it supports > both clear text and md5 versions of the password. Editing the grub > entries and command-line are disabled when some password is set in > domain''s grub.conf file but the password was not entered yet. Also, > new option to press ''p'' in interactive pygrub has been added to allow > entering the grub password. It''s been tested on x86_64 with PV guests > and was working fine. Also, the countdown has been stopped after key > was pressed, ie. the user is probably editing the boot configuration. > > Michal > > Signed-off-by: Michal Novotny <minovotn@redhat.com> > ------------------------------------------------------------------------ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Michal Novotny
2009-Aug-21 13:44 UTC
Re: [Xen-devel] [PATCH] Add password support to pygrub for GRUB bootloader
Hi, this patch (applied as http://xenbits.xensource.com/xen-unstable.hg?rev/8f783adc0ee3 , c/s 20099) introduced a problem for Itanium systems using LiloConf. This patch is the fix for elilo. Since I am unable to find information whether eLilo supports password protection or not, this patch makes the entry and command-line editing on IA64 systems as if no patch with c/s 20099 was applied. Also, this version changes the exception trapping from KeyError to every exception because of pyGrub would return no result and tools would complain about that having exception instead of providing data... Michal Signed-off-by: Michal Novotny <minovotn@redhat.com>> Michal Novotny wrote: >> Hi, >> this is the patch to add password support to pygrub for GRUB >> bootloader. It basically checks for the presence of password line in >> grub.conf of the guest image and if this line is present, it supports >> both clear text and md5 versions of the password. Editing the grub >> entries and command-line are disabled when some password is set in >> domain''s grub.conf file but the password was not entered yet. Also, >> new option to press ''p'' in interactive pygrub has been added to allow >> entering the grub password. It''s been tested on x86_64 with PV guests >> and was working fine. Also, the countdown has been stopped after key >> was pressed, ie. the user is probably editing the boot configuration. >> >> Michal >> >> Signed-off-by: Michal Novotny <minovotn@redhat.com> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > > ------------------------------------------------------------------------ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel