Pasi Kärkkäinen
2009-Aug-19 17:21 UTC
[Xen-devel] [PATCH] fix pygrub domU grub.conf timeout=0 handling
Hello, When you install Fedora 11 PV domU/guest with virt-install or virt-manager, it will have timeout=0 in it''s grub.conf. This is a new default in F11. pygrub of Xen 3.4.1 doesn''t seem to be able to handle timeout=0, instead it waits the user to press ENTER.. this causes confusion and makes it look like the guest has crashed. Graphical VNC console is not yet available at this point, so the kernel can be only chosen from "xm console <f11domain>", where pygrub is waiting for user input. This patch fixes the problem and let''s you start F11 domUs without going to the text console to select the kernel. The change is taken from the RHEL5.3 version of pygrub. Patch is tested with Fedora 11 (timeout=0) and CentOS 5.3 (timeout=5) domUs. -- Pasi _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Pasi Kärkkäinen
2009-Aug-19 17:27 UTC
Re: [Xen-devel] [PATCH] fix pygrub domU grub.conf timeout=0 handling
On Wed, Aug 19, 2009 at 08:21:28PM +0300, Pasi Kärkkäinen wrote:> Hello, > > When you install Fedora 11 PV domU/guest with virt-install or virt-manager, > it will have timeout=0 in it''s grub.conf. This is a new default in F11. > > pygrub of Xen 3.4.1 doesn''t seem to be able to handle timeout=0, instead it > waits the user to press ENTER.. this causes confusion and makes it look > like the guest has crashed. Graphical VNC console is not yet available at > this point, so the kernel can be only chosen from "xm console <f11domain>", > where pygrub is waiting for user input. > > This patch fixes the problem and let''s you start F11 domUs without going to > the text console to select the kernel. The change is taken from the > RHEL5.3 version of pygrub. > > Patch is tested with Fedora 11 (timeout=0) and CentOS 5.3 (timeout=5) domUs. >And actually attached this time. -- Pasi _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Aug-20 07:32 UTC
Re: [Xen-devel] [PATCH] fix pygrub domU grub.conf timeout=0 handling
On 19/08/2009 18:27, "Pasi Kärkkäinen" <pasik@iki.fi> wrote:>> pygrub of Xen 3.4.1 doesn''t seem to be able to handle timeout=0, instead it >> waits the user to press ENTER.. this causes confusion and makes it look >> like the guest has crashed. Graphical VNC console is not yet available at >> this point, so the kernel can be only chosen from "xm console <f11domain>", >> where pygrub is waiting for user input. >> >> This patch fixes the problem and let''s you start F11 domUs without going to >> the text console to select the kernel. The change is taken from the >> RHEL5.3 version of pygrub. >> >> Patch is tested with Fedora 11 (timeout=0) and CentOS 5.3 (timeout=5) domUs. >> > > And actually attached this time.Really this is a reversion of c/s 19322, which was a dodgy bugfix for Solaris. So I just checked it in as a reversion. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Pasi Kärkkäinen
2009-Aug-20 08:12 UTC
Re: [Xen-devel] [PATCH] fix pygrub domU grub.conf timeout=0 handling
On Thu, Aug 20, 2009 at 08:32:34AM +0100, Keir Fraser wrote:> On 19/08/2009 18:27, "Pasi Kärkkäinen" <pasik@iki.fi> wrote: > > >> pygrub of Xen 3.4.1 doesn''t seem to be able to handle timeout=0, instead it > >> waits the user to press ENTER.. this causes confusion and makes it look > >> like the guest has crashed. Graphical VNC console is not yet available at > >> this point, so the kernel can be only chosen from "xm console <f11domain>", > >> where pygrub is waiting for user input. > >> > >> This patch fixes the problem and let''s you start F11 domUs without going to > >> the text console to select the kernel. The change is taken from the > >> RHEL5.3 version of pygrub. > >> > >> Patch is tested with Fedora 11 (timeout=0) and CentOS 5.3 (timeout=5) domUs. > >> > > > > And actually attached this time. > > Really this is a reversion of c/s 19322, which was a dodgy bugfix for > Solaris. So I just checked it in as a reversion. >Thanks! -- Pasi _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel