Xen devel - Jul 2009 - [PATCH] default the videoram to 4MB when it is not set

Hi all,
this patch sets the videoram size to 4MB in case the size is not set
explicitly by the user or the toolstack.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

---

diff --git a/vl.c b/vl.c
index 8ad9c9e..2823939 100644
--- a/vl.c
+++ b/vl.c
@@ -5667,6 +5667,10 @@ int main(int argc, char **argv, char **envp)
     {
        fprintf(stderr,"-videoram option does not work with cirrus vga
device model. Videoram set to 4M.\n");
        vga_ram_size = 4 * 1024 * 1024;
+    /* if vga_ram_size is not set and a videocard is required, default it to 4
MB */
+    } else if ( !vga_ram_size && (std_vga_enabled || vmsvga_enabled) )
{
+       fprintf(stderr,"Defaulting vram to 8MB\n");
+       vga_ram_size = 4 * 1024 * 1024;
     }
 
     phys_ram_size = (machine->ram_require + vga_ram_size) &
~RAMSIZE_FIXED;

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefano Stabellini, le Tue 28 Jul 2009 14:01:41 +0100, a écrit
:
> +    /* if vga_ram_size is not set and a videocard is required, default it
to 4 MB */
> +    } else if ( !vga_ram_size && (std_vga_enabled ||
vmsvga_enabled) ) {
> +       fprintf(stderr,"Defaulting vram to 8MB\n");
typo here :)
> +       vga_ram_size = 4 * 1024 * 1024;
Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, 28 Jul 2009, Samuel Thibault wrote:
> Stefano Stabellini, le Tue 28 Jul 2009 14:01:41 +0100, a écrit :
> > +    /* if vga_ram_size is not set and a videocard is required,
default it to 4 MB */
> > +    } else if ( !vga_ram_size && (std_vga_enabled ||
vmsvga_enabled) ) {
> > +       fprintf(stderr,"Defaulting vram to 8MB\n");
> 
> typo here :)
> 
> > +       vga_ram_size = 4 * 1024 * 1024;
> 
Ooops, thanks for catching it :)

this is the fixed version:

---

diff --git a/vl.c b/vl.c
index 8ad9c9e..62bed05 100644
--- a/vl.c
+++ b/vl.c
@@ -5667,6 +5667,10 @@ int main(int argc, char **argv, char **envp)
     {
        fprintf(stderr,"-videoram option does not work with cirrus vga
device model. Videoram set to 4M.\n");
        vga_ram_size = 4 * 1024 * 1024;
+    /* if vga_ram_size is not set and a videocard is required, default it to 4
MB */
+    } else if ( !vga_ram_size && (std_vga_enabled || vmsvga_enabled) )
{
+       fprintf(stderr,"Defaulting vram to 4MB\n");
+       vga_ram_size = 4 * 1024 * 1024;
     }
 
     phys_ram_size = (machine->ram_require + vga_ram_size) &
~RAMSIZE_FIXED;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel