Andreas Florath
2009-Jul-27 17:18 UTC
[Xen-devel] [PATCH] Add script to compile different versions of python; add python syntax checker
Hello! Because my last patch [1] had some problems running under python-2.3 (and it looks, that I''m not the only one having this problem [2] [3]), I wrote some scripts which compile different versions of python. Additionally these scripts do a syntax check of all python code using these different python versions. This patch makes it easy to test the python code for different versions of python: only the LD_LIBRATY_PATH and PATH must be adapted. Currently supported: 2.3.7, 2.4.6, 2.5.4, 2.6.2, 3.1 Please consult the ''tests/README'' how to use. (It''s mostly a ''cd tests && make''). Kind regards Andreas Florath [1] http://lists.xensource.com/archives/html/xen-devel/2009-07/msg00900.html [2] http://lists.xensource.com/archives/html/xen-devel/2009-07/msg00618.html [3] http://lists.xensource.com/archives/html/xen-devel/2009-07/msg00616.html P.S.: First results: Compiling ../tools/xm-test/tests/block-create/10_block_attach_dettach_multiple_devices.py ... File "../tools/xm-test/tests/block-create/10_block_attach_dettach_multiple_devices.py", line 10 from os import path.basename ^ SyntaxError: invalid syntax for all versions of python. (Even after fixing this syntax error, there is at least another one.) Sorry, but currently I''m not able to send a patch for this, because I have major problems running the xm-test suite. N.B.: Second result: python-3.1 does not work at the moment (227 Syntax errors, mostly all because of the ''print arg'' vs. ''print(arg)'', and ''except Exception, e:'' vs. ''except Exception as e:''). It looks that it might be possible to fix all the ''print''s - but the new exception syntax is only implemented in python 2.6 (and AFAIK not in 2.3, 2.4 or 2.5). _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Andreas Florath
2009-Jul-29 04:40 UTC
Re: [Xen-devel] [PATCH] Add script to compile different versions of python; add python syntax checker
Hello Community, Hello Keir, just recognised that the patch was applied - but the directory is now different from the original. This breaks the Makefile and the provided scripts. I''ll send a patch against the current tip this evening. Kind regards Andreas Florath _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-Jul-29 07:40 UTC
Re: [Xen-devel] [PATCH] Add script to compile different versions of python; add python syntax checker
On 29/07/2009 05:40, "Andreas Florath" <xen@flonatel.org> wrote:> just recognised that the patch was applied - but the directory is now > different from the original. This breaks the Makefile and the provided > scripts. > > I''ll send a patch against the current tip this evening.Ah, I just assumed it would all be relative to the directory it''s resident in. Of course XEN_ROOT does need fixing (I forgot about that), but then you can make yourself a local-dir variable based directly on $(PWD) rather than $(XEN_ROOT). Also, at the same time it would be good if you would replace ${} make variable expansions with $(). It''s purely a style consistency thing, as we use the latter in all other Makefiles. Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Andreas Florath
2009-Jul-29 19:34 UTC
Re: [Xen-devel] [PATCH] Add script to compile different versions of python; add python syntax checker
Hello! The move breaks some paths and scripts. The applied patch fixes them. Additional changes: o scripts and Makefile are mostly location independent now (exception XEN_ROOT in Makefile) o use of $() instead of ${} in Makefile Kind regards Andreas Florath _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel