Simon Horman
2009-Jul-21 11:12 UTC
[Xen-devel] [patch] xend: pass-through: fix regression in the ordering of the output of xm pci list
changeset "python: Remove tab indents" (19937:e845326ae203)
introduces a minor regression in the multi-function PCI pass-through
code by causing bogus return values from the sort function
which is used to order the output of "xm pci list".
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: xen-unstable.hg/tools/python/xen/xm/main.py
==================================================================---
xen-unstable.hg.orig/tools/python/xen/xm/main.py 2009-07-21 18:51:29.000000000
+1000
+++ xen-unstable.hg/tools/python/xen/xm/main.py 2009-07-21 18:51:41.000000000
+1000
@@ -2234,7 +2234,7 @@ def xm_pci_list(args):
vdevfn = AUTO_PHP_SLOT
else:
vdevfn = x[''vdevfn'']
- return (vdevfn << 32) | \
+ return (vdevfn << 32) | \
PCI_BDF(x[''domain''],
x[''bus''], x[''slot''],
x[''func''])
devs.sort(None, f)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel