Hi! Changeset 19639 changed the ABI/API w/o taking care about backward compatibility. This breaks the xen build in upstream qemu in file hw/xen_domainbuild.c FYI, Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 20/07/2009 13:44, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> Hi! > > Changeset 19639 changed the ABI/API w/o taking care about backward > compatibility. > This breaks the xen build in upstream qemu in file hw/xen_domainbuild.cIs xc_linux_build() the only problematic function? That one could be reverted easily enough. Actually superpages should really just get bunged in ''struct xc_dom_image'' I think. Then the interface for all domain builder functions reverts to what it was previously. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Monday 20 July 2009 16:15:31 Keir Fraser wrote:> On 20/07/2009 13:44, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Hi! > > > > Changeset 19639 changed the ABI/API w/o taking care about backward > > compatibility. > > This breaks the xen build in upstream qemu in file hw/xen_domainbuild.c > > Is xc_linux_build() the only problematic function? That one could be > reverted easily enough. Actually superpages should really just get bunged > in ''struct xc_dom_image'' I think. Then the interface for all domain builder > functions reverts to what it was previously.For qemu, xc_linux_build() is the only one problematic function. From the engineering point-of-view, your proposal to collapse superpages into ''struct xc_dom_image'' is the best solution. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 20/07/2009 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote:>> Is xc_linux_build() the only problematic function? That one could be >> reverted easily enough. Actually superpages should really just get bunged >> in ''struct xc_dom_image'' I think. Then the interface for all domain builder >> functions reverts to what it was previously. > > For qemu, xc_linux_build() is the only one problematic function. > From the engineering point-of-view, your proposal to collapse superpages > into ''struct xc_dom_image'' is the best solution.Try changeset 19963. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Monday 20 July 2009 16:49:01 Keir Fraser wrote:> On 20/07/2009 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > >> Is xc_linux_build() the only problematic function? That one could be > >> reverted easily enough. Actually superpages should really just get > >> bunged in ''struct xc_dom_image'' I think. Then the interface for all > >> domain builder functions reverts to what it was previously. > > > > For qemu, xc_linux_build() is the only one problematic function. > > From the engineering point-of-view, your proposal to collapse superpages > > into ''struct xc_dom_image'' is the best solution. > > Try changeset 19963.Confirmed. This unbreaks build of qemu. Tnx for fixing. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel