KUWAMURA Shin''ya
2009-Jul-17 07:26 UTC
[Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3
Hi, This removes set() for Python 2.3, since set() is added from Python 2.4. Signed-off-by: KUWAMURA Shin''ya <kuwa@jp.fujitsu.com> -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Jul-17 13:30 UTC
Re: [Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3
KUWAMURA Shin''ya writes ("[Xen-devel] [PATCH] blktap2: Remove
set() for Python 2.3"):> This removes set() for Python 2.3, since set() is added from Python 2.4.
This looks reasonable to me, although I haven''t tested it.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Simon Horman
2009-Jul-21 03:41 UTC
Re: [Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3
On Fri, Jul 17, 2009 at 04:26:38PM +0900, KUWAMURA Shin''ya wrote:> Hi, > > This removes set() for Python 2.3, since set() is added from Python 2.4.set() seems to be used in a number of other places in the code. Is that a problem? # grep -r [^a-z_]set\( tools/python/xen/ tools/python/xen/util/acmpolicy.py: bad_renamings = set(vmlabel_map.keys()) - set(oldvmnames) tools/python/xen/util/acmpolicy.py: bad_renamings = set(reslabel_map.keys()) - set(oldresnames) tools/python/xen/util/acmpolicy.py: len( set(res_stes).intersection( set(vm_stes) ) ) == 0: tools/python/xen/util/acmpolicy.py: unknown_ste = set() tools/python/xen/util/acmpolicy.py: unknown_chw = set() tools/python/xen/util/acmpolicy.py: if len(vmlabels) != len(set(vmlabels)) or \ tools/python/xen/util/acmpolicy.py: len(resnames) != len(set(resnames)) or \ tools/python/xen/util/acmpolicy.py: len(stes) != len(set(stes)) or \ tools/python/xen/util/acmpolicy.py: len(chws) != len(set(chws)): tools/python/xen/util/acmpolicy.py: unknown_chw |= (set(chws_by_vm[v]) - set(chws)) tools/python/xen/util/acmpolicy.py: unknown_ste |= (set(stes_by_vm[v]) - set(stes)) tools/python/xen/util/acmpolicy.py: unknown_ste |= (set(stes_by_res[r]) - set(stes)) tools/python/xen/util/pci.py: if len(l) != len(set(l)): tools/python/xen/xend/XendAPI.py: ''classes'' : set(), tools/python/xen/xend/XendDomainInfo.py: # just itterating through set(map(..., pci_devs)) tools/python/xen/xend/XendDomainInfo.py: done = set() tools/python/xen/xend/XendDomainInfo.py: done |= set([key]) tools/python/xen/xend/server/DevController.py: ev.set() tools/python/xen/xend/server/DevController.py: ev.set() tools/python/xen/xend/server/DevController.py: ev.set() tools/python/xen/xend/server/pciif.py: if len(pci_str_list) != len(set(pci_str_list)): tools/python/xen/xm/labels.py: names = list(set(names1).union(names2)) tools/python/xen/xm/main.py: def set(keys, val): tools/python/xen/xm/main.py: lambda x: set([''MAC''], x), tools/python/xen/xm/main.py: lambda x: set([''network''], get_net_from_bridge(x)), tools/python/xen/xm/main.py: lambda x: set([''other_config'', ''ip''], x), tools/python/xen/xm/main.py: lambda x: set([''other_config'', ''script''], x), tools/python/xen/xm/main.py: lambda x: set([''other_config'', ''backend''], x), tools/python/xen/xm/main.py: lambda x: set([''device''], x), tools/python/xen/xm/main.py: lambda x: set([''qos_algorithm_params'', ''rate''], x), tools/python/xen/xm/main.py: lambda x: set([''other_config'', ''accel''], x) tools/python/xen/xm/main.py: if len(set(vdevfns)) > 1: tools/python/xen/xm/opts.py: self.set(default) tools/python/xen/xm/opts.py: self.set(self.default) tools/python/xen/xm/opts.py: def set(self, value): tools/python/xen/xm/opts.py: self.set(v) tools/python/xen/xm/opts.py: return opt.set(val) tools/python/xen/xm/opts.py: opt.set(1) tools/python/xen/xm/opts.py: opt.set(0) tools/python/xen/xm/opts.py: opt.set(1) tools/python/xen/xm/opts.py: opt.set(0) tools/python/xen/xm/opts.py: opt.set(v) tools/python/xen/xm/opts.py: opt.set(v) tools/python/xen/xm/opts.py: opt.set(v) tools/python/xen/xm/opts.py: opt.set(v) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
KUWAMURA Shin''ya
2009-Jul-21 04:11 UTC
Re: [Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3
Hi,>>>>> On Tue, 21 Jul 2009 13:41:59 +1000 >>>>> horms@verge.net.au(Simon Horman) said: > > On Fri, Jul 17, 2009 at 04:26:38PM +0900, KUWAMURA Shin''ya wrote: > > > This removes set() for Python 2.3, since set() is added from Python 2.4. > set() seems to be used in a number of other places in the code. > Is that a problem?They cause a problem only when the corresponding feature is used. # XenAPI, ACM, etc. But starting xend failed by the following code:> tools/python/xen/util/pci.py: if len(l) != len(set(l)):I removed it on weekly testing ad hoc. Best regards, -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2009-Jul-23 12:23 UTC
Re: [Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3
How about creating a file which includes the followings and import it? +# for 2.3 compatibility +try: + set() +except NameError: + from sets import Set as set On Tue, Jul 21, 2009 at 01:11:39PM +0900, KUWAMURA Shin''ya wrote:> Hi, > > >>>>> On Tue, 21 Jul 2009 13:41:59 +1000 > >>>>> horms@verge.net.au(Simon Horman) said: > > > > On Fri, Jul 17, 2009 at 04:26:38PM +0900, KUWAMURA Shin''ya wrote: > > > > > This removes set() for Python 2.3, since set() is added from Python 2.4. > > set() seems to be used in a number of other places in the code. > > Is that a problem? > > They cause a problem only when the corresponding feature is used. > # XenAPI, ACM, etc. > > But starting xend failed by the following code: > > tools/python/xen/util/pci.py: if len(l) != len(set(l)): > > I removed it on weekly testing ad hoc. > > Best regards,-- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
KUWAMURA Shin''ya
2009-Jul-24 07:43 UTC
Re: [Xen-devel] [PATCH] blktap2: Remove set() for Python 2.3
Hi, On <20090723122323.GD12574%yamahata@valinux.co.jp>, Isaku Yamahata wrote:> > How about creating a file which includes the followings > and import it? > > +# for 2.3 compatibility > +try: > + set() > +except NameError: > + from sets import Set as setGood! Xend can start on Python 2.3. Thank you. Best regards, -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel