Christoph Egger
2009-Jul-15 15:09 UTC
[Xen-devel] [PATCH] tools: simplify install of python "binaries"
Hi! Attached patch simplifies install of python "binaries". Get rid of get-path. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Jul-15 16:09 UTC
Re: [Xen-devel] [PATCH] tools: simplify install of python "binaries"
Christoph Egger writes ("[Xen-devel] [PATCH] tools: simplify install of
python "binaries""):> Attached patch simplifies install of python "binaries".
> Get rid of get-path.
I don''t think this is correct.
The purpose of the code you are removing here is to find out what the
compile-time python version is, and then hardcode that into the #!
line of the installed python scripts.
So if you compile with PYTHON=python2.4 or with PYTHON unset on a
system where `python'' from the path is 2.4, you generate in
dist/install/ (a) python modules in .../site-packages/python2.4 and
(b) scripts starting #!/usr/bin/python2.4
If you don''t do this then the script starts #!/usr/bin/python and if
by then python 2.5 is installed, it won''t find the modules.
Nacked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2009-Jul-16 08:08 UTC
Re: [Xen-devel] [PATCH] tools: simplify install of python "binaries"
On Wednesday 15 July 2009 17:09:58 Christoph Egger wrote:> Hi! > > Attached patch simplifies install of python "binaries". > Get rid of get-path. > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>Previous version doesn''t work due to missing part. Attached patch is the complete one. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Jul-16 13:57 UTC
Re: [Xen-devel] [PATCH] tools: simplify install of python "binaries"
Christoph Egger writes ("Re: [Xen-devel] [PATCH] tools: simplify install of
python "binaries""):> Previous version doesn''t work due to missing part. Attached patch
> is the complete one.
I still disagree with the this change, as explained.
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Nacked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel