Ian, shouldn''t the error path allocations in drivers/xen/xenbus/xenbus_client.c (in error_path() and _dev_error()) also be converted to GFP_NOIO? Thanks, Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, 2008-06-13 at 07:59 +0100, Jan Beulich wrote:> Ian, > > shouldn''t the error path allocations in drivers/xen/xenbus/xenbus_client.c > (in error_path() and _dev_error()) also be converted to GFP_NOIO?Possibly, although the only time I think It would matter was if you got an error while reattaching the disk with the swap on it, in which case you aren''t likely to get very far anyway... Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Apparently Analagous Threads
- [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
- [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
- [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
- [PATCH 0001/001] xen: multi page ring support for block devices
- [PATCH 0001/001] xen: multi page ring support for block devices