Do not use the DEFINE_RWLOCK macro, as it is not available when compiled against older kernels, such as SLES9''s 2.6.5 Signed-off-by: Ben Guthro <bguthro@virtualron.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2007-Aug-29 18:37 UTC
Re: [Xen-devel] [PATCH 1/3] Do not use DEFINE_RWLOCK Macro
On Wed, 2007-08-29 at 14:20 -0400, Ben Guthro wrote:> Do not use the DEFINE_RWLOCK macro, as it is not available when compiled > against older kernels, such as SLES9''s 2.6.5Things like this should generally be done by adding a suitably guarded definition of DEFINE_RWLOCK to the platform-compat.h header in unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ben Guthro
2007-Aug-29 20:31 UTC
Re: [Xen-devel] [PATCH 1/3] Do not use DEFINE_RWLOCK Macro
Revised patch attached. Note that I did run into a problem with a buggy kernel in RHEL4-U3. It seems that in this macro, rw_lock_t was used instead of rwlock_t. I added a line to platform-compat.h to account for this. Ben Signed-off-by: Ben Guthro <bguthro@virtualiron.com> Ian Campbell wrote:> On Wed, 2007-08-29 at 14:20 -0400, Ben Guthro wrote: > >> Do not use the DEFINE_RWLOCK macro, as it is not available when compiled >> against older kernels, such as SLES9''s 2.6.5 >> > > Things like this should generally be done by adding a suitably guarded > definition of DEFINE_RWLOCK to the platform-compat.h header in > unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h. > > Ian. > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel