Ben Guthro
2007-Aug-27 18:45 UTC
[Xen-devel] [PATCH][QEMU] Allow more IDE power management
Made the QEMU IDE disk tolerate more power-mgmt commands, specifically: WIN_SETFEATURE(EN_AAM) - enable automatic acoustic mgmt WIN_SETFEATURE(DIS_AAM) - disable automatic acoustic mgmt WIN_SETFEATURE(DIS_APM) - disable automatic power mgmt WIN_STANDBY WIN_SETIDLE1 WIN_SLEEPNOW1 WIN_STANDBY2 WIN_SETIDLE2 WIN_SLEEPNOW2 WIN_STANDBYNOW2 These are all essentially no-ops, like existing support for EN_RLA (enable read lookahead) and WIN_STANDBYNOW1. This fixes a crash in the SLES9-SP3 64bit kernel when the powersaved was started (with ACPI or ACM). This guest really only needs EN_AAM, DIS_APM, and WIN_SETIDLE1 support, but the others seemed sensible to include. I''ve excluded EN_APM since I''m unsure of what that''s agreeing to do. It''s probably ok to include. Signed-off-by: Ben Guthro <bguthro@virtualiron.com> Signed-off-by: David Lively <dlively@virtualiron.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Daniel P. Berrange
2007-Aug-27 19:19 UTC
Re: [Xen-devel] [PATCH][QEMU] Allow more IDE power management
On Mon, Aug 27, 2007 at 02:45:40PM -0400, Ben Guthro wrote:> Made the QEMU IDE disk tolerate more power-mgmt commands, specifically: > WIN_SETFEATURE(EN_AAM) - enable automatic acoustic mgmt > WIN_SETFEATURE(DIS_AAM) - disable automatic acoustic mgmt > WIN_SETFEATURE(DIS_APM) - disable automatic power mgmt > WIN_STANDBY > WIN_SETIDLE1 > WIN_SLEEPNOW1 > WIN_STANDBY2 > WIN_SETIDLE2 > WIN_SLEEPNOW2 > WIN_STANDBYNOW2 > These are all essentially no-ops, like existing support for EN_RLA (enable > read lookahead) and WIN_STANDBYNOW1. > > This fixes a crash in the SLES9-SP3 64bit kernel when the powersaved was > started (with ACPI or ACM). This guest really only needs EN_AAM, DIS_APM, > and WIN_SETIDLE1 support, but the others seemed sensible to include. > > I''ve excluded EN_APM since I''m unsure of what that''s agreeing to do. It''s > probably ok to include.This and other QEMU patches should really be sent to upstream QEMU for review and inclusion first so we don''t have to maintain extra patches in Xen forever. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel