Kouya Shimura
2007-Aug-14 07:04 UTC
[Xen-devel] [PATCH][TOOL] Fix infinite loop in xenconsoled
xenconsoled hungs when domid=(DOMID_FIRST_RESERVED-1). (i.e. domid + 1 == DOMID_SELF) Attached patch fixes it. Thanks, Kouya Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Aug-14 08:41 UTC
Re: [Xen-devel] [PATCH][TOOL] Fix infinite loop in xenconsoled
Wow, that''s nasty. The better fix is just not to have getdomaininfo() recognise DOMID_SELF. No good can come of it and noone relies on it, I''m certain. This was introduced by c/s 8394 but there''s never been a user in the tree. That''s the fix I''ll apply to -unstable. Thanks for tracking this one down! -- Keir On 14/8/07 08:04, "Kouya Shimura" <kouya@jp.fujitsu.com> wrote:> xenconsoled hungs when domid=(DOMID_FIRST_RESERVED-1). > (i.e. domid + 1 == DOMID_SELF) > Attached patch fixes it. > > Thanks, > Kouya > > Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com> > > diff -r 7953164cebb6 tools/console/daemon/io.c > --- a/tools/console/daemon/io.c Tue Aug 07 09:07:29 2007 +0100 > +++ b/tools/console/daemon/io.c Tue Aug 14 15:36:23 2007 +0900 > @@ -569,6 +569,8 @@ void enum_domains(void) > create_domain(dominfo.domid); > } > domid = dominfo.domid + 1; > + if (domid >= DOMID_FIRST_RESERVED) > + break; > } > } > > diff -r 7953164cebb6 tools/libxc/xc_domain.c > --- a/tools/libxc/xc_domain.c Tue Aug 07 09:07:29 2007 +0100 > +++ b/tools/libxc/xc_domain.c Tue Aug 14 15:36:23 2007 +0900 > @@ -205,6 +205,10 @@ int xc_domain_getinfo(int xc_handle, > sizeof(xen_domain_handle_t)); > > next_domid = (uint16_t)domctl.domain + 1; > + if (next_domid >= DOMID_FIRST_RESERVED) { > + nr_doms++; > + break; > + } > info++; > } > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel