Xen devel - Feb 2007 - RE: [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump on Dom0

> Put the Linux definition in xc_linux.c. Put a default dummy
> implementation
> in xc_private.c with __attribute__ ((weak)). If you have only a
> function
> prototype in xc_private.h then you won''t need -D_GNU_SOURCE for
> xcutil/Makefile.
This wont quite work -- xc_private.c isn''t part of libxenguest which
includes save/restore which needs the function... that''s why I made it
inline in xc_private.h which is included everywhere...

/simgr


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 23/2/07 18:48, "Graham, Simon" <Simon.Graham@stratus.com>
wrote:
>> Put the Linux definition in xc_linux.c. Put a default dummy
>> implementation
>> in xc_private.c with __attribute__ ((weak)). If you have only a
>> function
>> prototype in xc_private.h then you won''t need -D_GNU_SOURCE
for
>> xcutil/Makefile.
> 
> This wont quite work -- xc_private.c isn''t part of libxenguest
which
> includes save/restore which needs the function... that''s why I
made it
> inline in xc_private.h which is included everywhere...
Libxenguest links against libxenctrl: it uses plenty of functions from
libxenctrl already (xc_domain_getinfo() to name just one example).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel