Graham, Simon
2007-Feb-23 18:32 UTC
RE: [Xen-devel] [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump on Dom0
> 2. You need it in xcutil because this directory has code that includes > xc_private.h -- this seems wrong/bad to me but I wasn''t prepared > to change it! >Actually, it''s xcutils/readnotes.c that #include''s xg_private.h (which in turn includes xc_private.h) -- since the function that does the advise call is inline in xc_private.h, this wont compile unless _GNU_SOURCE is defined... Simon _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2007-Feb-23 18:43 UTC
Re: [Xen-devel] [PATCH][TOOLS] Reducingimpactofdomainsave/restore/dump on Dom0
On 23/2/07 18:32, "Graham, Simon" <Simon.Graham@stratus.com> wrote:>> 2. You need it in xcutil because this directory has code that includes >> xc_private.h -- this seems wrong/bad to me but I wasn''t prepared >> to change it! >> > > Actually, it''s xcutils/readnotes.c that #include''s xg_private.h (which > in turn includes xc_private.h) -- since the function that does the > advise call is inline in xc_private.h, this wont compile unless > _GNU_SOURCE is defined...Put the Linux definition in xc_linux.c. Put a default dummy implementation in xc_private.c with __attribute__ ((weak)). If you have only a function prototype in xc_private.h then you won''t need -D_GNU_SOURCE for xcutil/Makefile. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel