Xen devel - Oct 2006 - [HVM][SVM][PATCH][2/2] Delay ExtInt Injection

Patch 2/2 -
Add flag to indicate that an exception event needs injecting, and to
delay
the ext interrupt injection.
Remove unnecessary check of RFLAGS.IF for ExtInt injection.

Applies cleanly to xen-unstable c/s 11831.
Please apply to xen-unstable.hg.

We would also want this patch to be in a 3.0.3-1 base whenever that is
branched.

Signed-off-by: Travis Betak <travis.betak@amd.com>
Signed-off-by: Wei Huang <wei.huang2@amd.com>
Signed-off-by: Tom Woller <thomas.woller@amd.com>
 
  --Tom


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 19/10/06 11:03 pm, "Woller, Thomas" <thomas.woller@amd.com>
wrote:
> Add flag to indicate that an exception event needs injecting, and to
> delay
> the ext interrupt injection.
> Remove unnecessary check of RFLAGS.IF for ExtInt injection.
Since EventInj is separate from V_IRQ, and both are supported simultaneously
(EventInj followed by V_IRQ, I hope!), why do you need to enforce mutual
exclusion favouring EventInj and delaying V_IRQ injection?

Removing the RFLAGS.IF check makes sense because the previous patch moves
the check later (and does dummy VIRQ injection instead of simply bailing).
But I don''t see why the EventInj check gets added by this patch.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> Since EventInj is separate from V_IRQ, and both are supported 
> simultaneously (EventInj followed by V_IRQ, I hope!), why do 
> you need to enforce mutual exclusion favouring EventInj and 
> delaying V_IRQ injection?
> 
> Removing the RFLAGS.IF check makes sense because the previous 
> patch moves the check later (and does dummy VIRQ injection 
> instead of simply bailing).
> But I don''t see why the EventInj check gets added by this patch.
We have seen issues when both fields are filled out and delaying the
V_IRQ injection until the next opportunity alleviates these problems.
We are looking into root cause and will then remove this code and allow
both EventInj and V_IRQ simultaneously, but timeframe on when that will
be is a bit unknown at this point.  Clearly we would want to take
advantage of the ucode''s ability to support both fields on the same
vmrun!
We have though, thoroughly tested (we believe) these patches.
Let me know if you have any other concerns/questions..
 
  --Tom



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel