Xen devel - Aug 2006 - PATCH: xencomm - kernel side

Hi,

taking into account Hollis comments I now submit this patch.

IA64 specific stuff will be posted to xen-ia64-unstable after merge.

Tristan.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Wed, 2006-08-23 at 14:31 +0200, Tristan Gingold
wrote:
> 
> taking into account Hollis comments I now submit this patch.
> 
> IA64 specific stuff will be posted to xen-ia64-unstable after merge.
NAK pending outcome of other comments.

Also, please let me add my own Signed-off-by line -- that way we''ll
know
that I agree the patch is in fact final (which I don''t right now).

There is at least a "/* XXX could we call this from irq context? */"
comment that needs removal. I didn''t check the rest of the patch to see
if you''d followed all my other suggestions.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Le Mercredi 23 Août 2006 18:39, Hollis Blanchard a écrit
:
> On Wed, 2006-08-23 at 14:31 +0200, Tristan Gingold wrote:
> > taking into account Hollis comments I now submit this patch.
> >
> > IA64 specific stuff will be posted to xen-ia64-unstable after merge.
>
> NAK pending outcome of other comments.
>
> Also, please let me add my own Signed-off-by line -- that way
we''ll know
> that I agree the patch is in fact final (which I don''t right now).
>
> There is at least a "/* XXX could we call this from irq context?
*/"
> comment that needs removal. I didn''t check the rest of the patch
to see
> if you''d followed all my other suggestions.
I think the comment could be removed as this is never call during irq.

Here are the full patches (common and ia64).  Only the common patches (mainly 
11059) was formally submitted.

Tristan.






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, 2006-08-24 at 17:27 +0200, Tristan Gingold
wrote:
> > There is at least a "/* XXX could we call this from irq context?
*/"
> > comment that needs removal. I didn''t check the rest of the
patch to see
> > if you''d followed all my other suggestions.
> I think the comment could be removed as this is never call during irq.
Fine, but that''s not actually what I was getting at. My point is that
the caller passes in gfp_mask, so if the caller is in IRQ context, it
can pass in the proper allocator flags, so there is no problem and the
comment should be removed.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel