Hollis Blanchard
2006-Jul-28 19:17 UTC
[Xen-devel] Re: [Xen-changelog] [xen-unstable] [IA64] Creates tools/libxc/ia64 directory.
On Fri, 2006-07-28 at 16:20 +0000, Xen patchbot-unstable wrote:> diff -r dc26ac2f7718 -r dab0a5650e6d tools/libxc/Makefile > --- a/tools/libxc/Makefile Mon Jul 10 14:14:11 2006 -0600 > +++ b/tools/libxc/Makefile Tue Jul 11 11:29:25 2006 -0600 > @@ -30,9 +30,11 @@ GUEST_SRCS-y += xc_load_bin.c > GUEST_SRCS-y += xc_load_bin.c > GUEST_SRCS-y += xc_load_elf.c > GUEST_SRCS-y += xg_private.c > -GUEST_SRCS-$(CONFIG_IA64) += xc_ia64_stubs.c > GUEST_SRCS-$(CONFIG_MIGRATE) += xc_linux_restore.c xc_linux_save.c > GUEST_SRCS-$(CONFIG_HVM) += xc_hvm_build.c > + > +# This Makefile only adds files if CONFIG_IA64 is y. > +include ia64/Makefile > > CFLAGS += -Werror > CFLAGS += -fno-strict-aliasingI''m not sure this is the best way. We''ll need to do the same thing for xc_ppc_linux_build.c, but it seems a little silly to unconditionally include powerpc/Makefile as well... perhaps -include $(XEN_TARGET_ARCH)/Makefile would suffice? -- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jul-28 21:56 UTC
Re: [Xen-devel] Re: [Xen-changelog] [xen-unstable] [IA64] Creates tools/libxc/ia64 directory.
On 28 Jul 2006, at 20:17, Hollis Blanchard wrote:> I''m not sure this is the best way. We''ll need to do the same thing for > xc_ppc_linux_build.c, but it seems a little silly to unconditionally > include powerpc/Makefile as well... perhaps > -include $(XEN_TARGET_ARCH)/Makefile > would suffice?That''s actually what I ended up checking in. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel