Xen devel - Jul 2006 - [PATCH] Add lost logic for VGA initialization

This patch adds lost logic for vga initialization. It was lost after
changing to new Qemu.
Signed-off-by : Kevin Tian <kevin.tian@intel.com>
Signed-off-by : Zhang Xiantao <xiantao.zhang@intel.com>

Thanks & Best Regards
-Xiantao

OTC,Intel Corporation



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 26 Jul 2006, at 05:46, Zhang, Xiantao wrote:
> This patch adds lost logic for vga initialization. It was lost after
> changing to new Qemu.
> Signed-off-by : Kevin Tian <kevin.tian@intel.com>
> Signed-off-by : Zhang Xiantao <xiantao.zhang@intel.com>
How come the new qemu code seems to have perfectly working VGA without 
this patch?

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 7/26/06, Zhang, Xiantao <xiantao.zhang@intel.com>
wrote:
> This patch adds lost logic for vga initialization. It was lost after
> changing to new Qemu.
> Signed-off-by : Kevin Tian <kevin.tian@intel.com>
> Signed-off-by : Zhang Xiantao <xiantao.zhang@intel.com>
I''ve applied this -- it would be nice if you could cleanup the code
some more to use arrays to initialize s->sr[], s->gr[], s->ar[] and
s->cr[].  Thanks!

    christian

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi, Christian
	Thank you for your comments. But I check the patch on tip. Seems the following
line not in upstream. I don''t know why this part was lost when
check-in.
diff -r 254c090854de tools/ioemu/hw/vga.c
--- a/tools/ioemu/hw/vga.c      Wed Jul 26 15:59:36 2006 -0600
+++ b/tools/ioemu/hw/vga.c      Thu Jul 27 09:27:03 2006 +0800
@@ -1953,6 +1953,7 @@ void vga_common_init(VGAState *s, Displa
                          vga_screen_dump, s);
     /* XXX: currently needed for display */
     vga_state = s;
+    vga_bios_init(s);
 }
Thanks & Best Regards
-Xiantao

OTC,Intel Corporation
> -----Original Message-----
> From: Christian Limpach [mailto:christian.limpach@gmail.com]
> Sent: 2006年7月26日 22:23
> To: Zhang, Xiantao
> Cc: xen-devel@lists.xensource.com; xen-ia64-devel@lists.xensource.com
> Subject: Re: [Xen-devel] [PATCH] Add lost logic for VGA initialization
> 
> On 7/26/06, Zhang, Xiantao <xiantao.zhang@intel.com> wrote:
> > This patch adds lost logic for vga initialization. It was lost after
> > changing to new Qemu.
> > Signed-off-by : Kevin Tian <kevin.tian@intel.com>
> > Signed-off-by : Zhang Xiantao <xiantao.zhang@intel.com>
> 
> I''ve applied this -- it would be nice if you could cleanup the
code
> some more to use arrays to initialize s->sr[], s->gr[], s->ar[]
and
> s->cr[].  Thanks!
> 
>     christian
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 7/27/06, Zhang, Xiantao <xiantao.zhang@intel.com>
wrote:
> Hi, Christian
>         Thank you for your comments. But I check the patch on tip. Seems
the following line not in upstream. I don't know why this part was lost when
check-in.
> diff -r 254c090854de tools/ioemu/hw/vga.c
> --- a/tools/ioemu/hw/vga.c      Wed Jul 26 15:59:36 2006 -0600
> +++ b/tools/ioemu/hw/vga.c      Thu Jul 27 09:27:03 2006 +0800
> @@ -1953,6 +1953,7 @@ void vga_common_init(VGAState *s, Displa
>                           vga_screen_dump, s);
>      /* XXX: currently needed for display */
>      vga_state = s;
> +    vga_bios_init(s);
>  }
Applied, I hope we've got it all now :-)

    christian
> Thanks & Best Regards
> -Xiantao
>
> OTC,Intel Corporation
>
> > -----Original Message-----
> > From: Christian Limpach [mailto:christian.limpach@gmail.com]
> > Sent: 2006年7月26日 22:23
> > To: Zhang, Xiantao
> > Cc: xen-devel@lists.xensource.com; xen-ia64-devel@lists.xensource.com
> > Subject: Re: [Xen-devel] [PATCH] Add lost logic for VGA initialization
> >
> > On 7/26/06, Zhang, Xiantao <xiantao.zhang@intel.com> wrote:
> > > This patch adds lost logic for vga initialization. It was lost
after
> > > changing to new Qemu.
> > > Signed-off-by : Kevin Tian <kevin.tian@intel.com>
> > > Signed-off-by : Zhang Xiantao <xiantao.zhang@intel.com>
> >
> > I've applied this -- it would be nice if you could cleanup the
code
> > some more to use arrays to initialize s->sr[], s->gr[],
s->ar[] and
> > s->cr[].  Thanks!
> >
> >     christian
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel