Xen devel - Jun 2006 - [PATCH][RESEND]Xenoprof passive domain support

Keir,
After several discussions with Renato, I remade the patch, which is
against c/s 10428. The main functionality remains the same, while it
takes more care of passive domain status cleanup, adopts a more
efficient lockup mechanism, a more consistent interface which is used by
active domain, and does some improvements of code style. 

Thanks,
Xiaowei


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Thanks Xiaowei.
The Xen component of the patch looks good to me.
However there are a few thinks I would like to modify in the linux
component.
I will revise the patch and post a new version in a few days.
Thanks

Renato
>> -----Original Message-----
>> From: Yang, Xiaowei [mailto:xiaowei.yang@intel.com] 
>> Sent: Monday, June 26, 2006 10:55 PM
>> To: Keir.Fraser@cl.cam.ac.uk; Santos, Jose Renato G; Nakajima, Jun
>> Cc: xen-devel@lists.xensource.com
>> Subject: [PATCH][RESEND]Xenoprof passive domain support
>> 
>> Keir,
>> After several discussions with Renato, I remade the patch, 
>> which is against c/s 10428. The main functionality remains 
>> the same, while it takes more care of passive domain status 
>> cleanup, adopts a more efficient lockup mechanism, a more 
>> consistent interface which is used by active domain, and 
>> does some improvements of code style. 
>> 
>> Thanks,
>> Xiaowei
>> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 28 Jun 2006, at 03:33, Santos, Jose Renato G wrote:
> Thanks Xiaowei.
> The Xen component of the patch looks good to me.
> However there are a few thinks I would like to modify in the linux
> component.
> I will revise the patch and post a new version in a few days.
> Thanks
I checked in the patch already, so make your patch relative to the 
previous one.

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

OK,

Renato 
>> -----Original Message-----
>> From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] 
>> Sent: Tuesday, June 27, 2006 11:47 PM
>> To: Santos, Jose Renato G
>> Cc: Yang, Xiaowei; xen-devel@lists.xensource.com; Nakajima, Jun
>> Subject: Re: [PATCH][RESEND]Xenoprof passive domain support
>> 
>> 
>> On 28 Jun 2006, at 03:33, Santos, Jose Renato G wrote:
>> 
>> > Thanks Xiaowei.
>> > The Xen component of the patch looks good to me.
>> > However there are a few thinks I would like to modify in the linux
>> > component.
>> > I will revise the patch and post a new version in a few days.
>> > Thanks
>> 
>> I checked in the patch already, so make your patch relative 
>> to the previous one.
>> 
>>   -- Keir
>> 
>> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tuesday 27 June 2006 00:55, Yang, Xiaowei wrote:
> Keir,
> After several discussions with Renato, I remade the patch, which is
> against c/s 10428. The main functionality remains the same, while it
> takes more care of passive domain status cleanup, adopts a more
> efficient lockup mechanism, a more consistent interface which is used by
> active domain, and does some improvements of code style.
>
> Thanks,
> Xiaowei
Xiaowei,

Hmmm... When I apply your patch to 10428, then try to compile 
linux-2.6.16.13-xen, it fails with the following:

  CC      arch/x86_64/oprofile/../../i386/oprofile/xenoprof.o
arch/i386/oprofile/xenoprof.c: In function `xenoprof_handle_passive'':
arch/i386/oprofile/xenoprof.c:160: error: `IGNORED_PC'' undeclared
(first use
in this function)
arch/i386/oprofile/xenoprof.c:160: error: (Each undeclared identifier is 
reported only once
arch/i386/oprofile/xenoprof.c:160: error: for each function it appears in.)
arch/i386/oprofile/xenoprof.c:160: error: `CPU_MODE_PASSIVE_START''
undeclared
(first use in this function)
arch/i386/oprofile/xenoprof.c:162: error: `CPU_MODE_PASSIVE_STOP''
undeclared
(first use in this function)
arch/i386/oprofile/xenoprof.c: At top level:
arch/i386/oprofile/xenoprof.c:449: error: unknown field `set_passive'' 
specified in initializer
arch/i386/oprofile/xenoprof.c:449: warning: initialization from incompatible 
pointer type
make[1]: *** [arch/x86_64/oprofile/../../i386/oprofile/xenoprof.o] Error 1

Any suggestions?
-- 
Ray Bryant
AMD Performance Labs                   Austin, Tx
512-602-0038 (o)                 512-507-7807 (c)



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Xiaowei,

OK, doing a "make world" after applying your patch got the 
patches/linux-2.6.16.13/xenoprof-generic.patch patch applied correctly and 
that solved my previous problem, but now I have a new one:

CC      arch/x86_64/oprofile/../../../drivers/oprofile/buffer_sync.o
drivers/oprofile/buffer_sync.c: In function `sync_buffer'':
drivers/oprofile/buffer_sync.c:522: error: `NO_DOMAIN_SWITCH''
undeclared
(first use in this function)
drivers/oprofile/buffer_sync.c:522: error: (Each undeclared identifier is 
reported only once
drivers/oprofile/buffer_sync.c:522: error: for each function it appears in.)
drivers/oprofile/buffer_sync.c:543: error: `DOMAIN_SWITCH_START_EVENT1''
undeclared (first use in this function)
drivers/oprofile/buffer_sync.c:545: error: `DOMAIN_SWITCH_STOP_EVENT1'' 
undeclared (first use in this function)
drivers/oprofile/buffer_sync.c:547: error: `DOMAIN_SWITCH_START_EVENT2''
undeclared (first use in this function)
make[1]: *** [arch/x86_64/oprofile/../../../drivers/oprofile/buffer_sync.o] 
Error 1
make: *** [arch/x86_64/oprofile] Error 2

There doesn''t appear to be a definition of these DOMAIN_SWITCH things
in your
patch or anywhere else in linux-2.6.16.13-xen nor on the xen side, so it 
seems to me your patch is broken here, somehow, unless there is some other 
"trick of the build" that I haven''t come across.


-- 
Ray Bryant
AMD Performance Labs                   Austin, Tx
512-602-0038 (o)                 512-507-7807 (c)



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>There doesn''t appear to be a definition of these DOMAIN_SWITCH
things
in your
>patch or anywhere else in linux-2.6.16.13-xen nor on the xen side, so
it
>seems to me your patch is broken here, somehow, unless there is some
other
>"trick of the build" that I haven''t come across.
>
Ray,
Thanks for pointing this out promptly! 
I don''t know what''s wrong with pristine-linux-2.6.16.13 in my
former
working directory. When I generated xenoprof-generic.patch, one segment
was just missing.

Keir,
Can you please apply this little fix? Thanks a lot!

-Xiaowei


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel