Jan Beulich
2006-Jun-26 13:53 UTC
[Xen-devel] page table walk in xen_{create, destroy}_contiguous_region
Is there a particular reason why these functions need to walk the page table rather than doing a much cheaper p2m translation? vstart is assumed to be in the direct mapping area anyway (otherwise the uses of __pa() in the same functions wouldn''t be valid). Thanks, Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Jun-26 21:05 UTC
Re: [Xen-devel] page table walk in xen_{create, destroy}_contiguous_region
On 26 Jun 2006, at 14:53, Jan Beulich wrote:> Is there a particular reason why these functions need to walk the page > table rather than doing a much cheaper p2m > translation? vstart is assumed to be in the direct mapping area anyway > (otherwise the uses of __pa() in the same > functions wouldn''t be valid). > > Thanks, JanLooks like the walks are not really needed. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2006-Jun-29 13:46 UTC
Re: [Xen-devel] page table walk in xen_{create, destroy}_contiguous_region
>> Is there a particular reason why these functions need to walk the page >> table rather than doing a much cheaper p2m >> translation? vstart is assumed to be in the direct mapping area anyway >> (otherwise the uses of __pa() in the same >> functions wouldn''t be valid). >> >> Thanks, Jan > >Looks like the walks are not really needed.Subject: Replace page table walks by simple address calculation Signed-off-by: jbeulich@novell.com Makes the code both smaller and faster. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel