Xen devel - Jun 2006 - [PATCH] balloon: don''t talk about low/high memory when there is no such distinction

.. in order to not confuse people.

Signed-off-by: Jan Beulich <jbeulich@novell.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Fri, Jun 23, 2006 at 02:26:38PM +0200, Jan Beulich wrote:
> .. in order to not confuse people.
Hi Jan,

This will confuse any tool that parses the output of the file
though. The ifdefs are also pretty ugly... is the current output so
confusing?

Cheers,
Muli

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Muli Ben-Yehuda wrote:
> On Fri, Jun 23, 2006 at 02:26:38PM +0200, Jan Beulich wrote:
>
>   
>> .. in order to not confuse people.
>>     
>
> Hi Jan,
>
> This will confuse any tool that parses the output of the file
> though. The ifdefs are also pretty ugly... is the current output so
> confusing?
>   
Xend actually relies on the output of /proc/xen/balloon.  See 
tools/python/xen/xend/balloon.py

Regards,

Anthony Liguori
> Cheers,
> Muli
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>   

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> Muli Ben-Yehuda <muli@il.ibm.com> 24.06.06 16:51 >>>
>On Fri, Jun 23, 2006 at 02:26:38PM +0200, Jan Beulich wrote:
>
>> .. in order to not confuse people.
>
>This will confuse any tool that parses the output of the file
>though. The ifdefs are also pretty ugly... is the current output so
>confusing?
I did get confused - I imagined ''high'' and
''low'' to be something entirely
different until I looked at the code in greater detail.

I generally consider tools depending on spelling or other similar things
broken. But of course, this is a personal opinion perhaps based on my
non-Unix/Linux origin.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 23 Jun 2006, at 13:26, Jan Beulich wrote:
> .. in order to not confuse people.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
Changing the output format across architectures isn''t very nice for 
scripts which may scrape the output. There''s also precedent 
(/proc/meminfo includes redundant high/low distinction even on 
architectures where it makes no sense).

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel