Hi, all
I have no x86_64 machine now.
So this patch is not tested.
But I think this is obviously wrong.
Please check x86_64 people. :-)
Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>
Best Regards,
Akio Takebe
diff -r b87ff075dab9 tools/xentrace/xenctx.c
--- a/tools/xentrace/xenctx.c Thu Jun 08 11:08:35 2006 -0600
+++ b/tools/xentrace/xenctx.c Sun Jun 25 13:35:32 2006 +0900
@@ -393,7 +393,11 @@ void dump_ctx(int vcpu)
}
print_ctx(&ctx);
+#if defined (__i386__)
if (is_kernel_text(ctx.user_regs.eip))
+#elif defined (__x86_64__)
+ if (is_kernel_text(ctx.user_regs.rip))
+#endif
print_stack(&ctx, vcpu);
ret = xc_domain_unpause(xc_handle, domid);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On 17 Jun 2006, at 08:47, Akio Takebe wrote:> I''m very sorry. This fix was already done by Tristan. > His patch posted to xen-ia64-devel, but not apply yet.Hopefully not that particular fix. The existing non-ifdef code works fine on both i386 and x86/64. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi, all I''m very sorry. This fix was already done by Tristan. His patch posted to xen-ia64-devel, but not apply yet. Best Regards, Akio Takebe>Hi, all > >I have no x86_64 machine now. >So this patch is not tested. >But I think this is obviously wrong. >Please check x86_64 people. :-) > >Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com> > >Best Regards, > >Akio Takebe > >diff -r b87ff075dab9 tools/xentrace/xenctx.c >--- a/tools/xentrace/xenctx.c Thu Jun 08 11:08:35 2006 -0600 >+++ b/tools/xentrace/xenctx.c Sun Jun 25 13:35:32 2006 +0900 >@@ -393,7 +393,11 @@ void dump_ctx(int vcpu) > } > > print_ctx(&ctx); >+#if defined (__i386__) > if (is_kernel_text(ctx.user_regs.eip)) >+#elif defined (__x86_64__) >+ if (is_kernel_text(ctx.user_regs.rip)) >+#endif > print_stack(&ctx, vcpu); > > ret = xc_domain_unpause(xc_handle, domid); > >-------------------------------text/plain------------------------------- >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi, Keir Yes, Tristan''s patch is non-ifdef fix. Best Regards, Akio Takebe> >On 17 Jun 2006, at 08:47, Akio Takebe wrote: > >> I''m very sorry. This fix was already done by Tristan. >> His patch posted to xen-ia64-devel, but not apply yet. > >Hopefully not that particular fix. The existing non-ifdef code works >fine on both i386 and x86/64. > > -- Keir_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel