Thanks to Anthony Liquori off the QEMU mailing list for this SDL mouse fix. The new mouse code can hit situation where it won''t move past `invisible wall` on the screen. This patch fixes that problem. Signed-off-by: Don Dugger <donald.d.dugger@intel.com> -- Don Dugger "Censeo Toto nos in Kansa esse decisse." - D. Gale Donald.D.Dugger@intel.com Ph: (303)440-1368 diff -r 6bffed2aa78b tools/ioemu/sdl.c --- a/tools/ioemu/sdl.c Mon Jun 12 17:56:20 2006 +0100 +++ b/tools/ioemu/sdl.c Wed Jun 14 10:10:36 2006 -0600 @@ -376,13 +376,18 @@ static void sdl_update_caption(void) static void sdl_hide_cursor(void) { - SDL_SetCursor(sdl_cursor_hidden); + if (kbd_mouse_is_absolute()) { + SDL_ShowCursor(1); + SDL_SetCursor(sdl_cursor_hidden); + } else { + SDL_ShowCursor(0); + } } static void sdl_show_cursor(void) { if (!kbd_mouse_is_absolute()) { - SDL_SetCursor(sdl_cursor_normal); + SDL_ShowCursor(1); } } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Anthony Liguori
2006-Jun-14 17:01 UTC
Re: [Xen-devel] [PATCH] Fix SDL mouse invisible wall
It''s rather curious as to whether this one needs my Signed-off-by since this is my patch verbatim :-) Just in case, Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> :-) Regards, Anthony Liguori Donald D. Dugger wrote:> Thanks to Anthony Liquori off the QEMU mailing list for this SDL mouse > fix. The new mouse code can hit situation where it won''t move past > `invisible wall` on the screen. This patch fixes that problem. > > > Signed-off-by: Don Dugger <donald.d.dugger@intel.com> > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Dugger, Donald D
2006-Jun-14 17:06 UTC
RE: [Xen-devel] [PATCH] Fix SDL mouse invisible wall
Anthony- Since I sent it I figured it was my responsibility (and I''m certainly fine with that) but adding yours just guarantees we''re correct. -- Don Dugger "Censeo Toto nos in Kansa esse decisse." - D. Gale Donald.D.Dugger@intel.com Ph: (303)440-1368>-----Original Message----- >From: Anthony Liguori [mailto:aliguori@us.ibm.com] >Sent: Wednesday, June 14, 2006 11:01 AM >To: Dugger, Donald D >Cc: xen-devel@lists.xensource.com >Subject: Re: [Xen-devel] [PATCH] Fix SDL mouse invisible wall > >It''s rather curious as to whether this one needs my >Signed-off-by since >this is my patch verbatim :-) > >Just in case, Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> :-) > >Regards, > >Anthony Liguori > >Donald D. Dugger wrote: >> Thanks to Anthony Liquori off the QEMU mailing list for this >SDL mouse >> fix. The new mouse code can hit situation where it won''t move past >> `invisible wall` on the screen. This patch fixes that problem. >> >> >> Signed-off-by: Don Dugger <donald.d.dugger@intel.com> >> >> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel