Xen devel - Jun 2006 - current hg unstable tree: arch/i386/kernel/built-in.o: In function `safe_halt'': undefined reference to `rcu_needs_cpu''

Hi,

kernel building doesn''t work witth current hg unstable tree and
2.6.16.20 on x86:

  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
arch/i386/kernel/built-in.o: In function `safe_halt'': undefined
reference to `rcu_needs_cpu''
make[1]: *** [.tmp_vmlinux1] Error 1
make[1]: Leaving directory
`/usr/src/xen/build/kernelbau-20060613.3-xen-unstable.hg-nosmp/linux-2.6.16.20-20060613.3-xen-unstable.hg-nosmp-xen''
make: *** [stamp-build] Error 2


Johnny

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

You need patches/linux-2.6.16.13/rcu_needs_cpu.patch from our  
repository.

  -- Keir


On 13 Jun 2006, at 14:05, Hans-Christian Armingeon wrote:
> Hi,
>
> kernel building doesn''t work witth current hg unstable tree and  
> 2.6.16.20 on x86:
>
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/i386/kernel/built-in.o: In function `safe_halt'': undefined  
> reference to `rcu_needs_cpu''
> make[1]: *** [.tmp_vmlinux1] Error 1
> make[1]: Leaving directory  
> `/usr/src/xen/build/kernelbau-20060613.3-xen-unstable.hg-nosmp/linux 
> -2.6.16.20-20060613.3-xen-unstable.hg-nosmp-xen''
> make: *** [stamp-build] Error 2
>
>
> Johnny
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

There''s a patch in patches/linux-2.6.16.13 called rcu_needs_cpu.patch
which provides rcu_needs_cpu for the 2.6.16.13 kernel which is the one I
tested against when I submitted the rcu_needs_cpu_patch.

I''m not sure how you are getting the 2.6.16.20 kernel.  If this is a
standard part of the xen-unstable build that is supposed to work then
let me know how to invoke it and I will fix up the problem.

But maybe you have pulled 2.6.16.20 manually, applied the 2.6.16.13
patches manually and then done an hg pull and got the new patch in the
patches directory but failed to apply it to your kernel?

Harry

On Tue, 2006-06-13 at 15:05 +0200, Hans-Christian Armingeon
wrote:
> Hi,
> 
> kernel building doesn''t work witth current hg unstable tree and
2.6.16.20 on x86:
> 
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/i386/kernel/built-in.o: In function `safe_halt'': undefined
reference to `rcu_needs_cpu''
> make[1]: *** [.tmp_vmlinux1] Error 1
> make[1]: Leaving directory
`/usr/src/xen/build/kernelbau-20060613.3-xen-unstable.hg-nosmp/linux-2.6.16.20-20060613.3-xen-unstable.hg-nosmp-xen''
> make: *** [stamp-build] Error 2
> 
> 
> Johnny
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Am Mittwoch, 14. Juni 2006 12:55 schrieb Harry
Butterworth:
> There''s a patch in patches/linux-2.6.16.13 called
rcu_needs_cpu.patch
> which provides rcu_needs_cpu for the 2.6.16.13 kernel which is the one I
> tested against when I submitted the rcu_needs_cpu_patch.
> 
> I''m not sure how you are getting the 2.6.16.20 kernel.  If this is
a
> standard part of the xen-unstable build that is supposed to work then
> let me know how to invoke it and I will fix up the problem.
> 
> But maybe you have pulled 2.6.16.20 manually, applied the 2.6.16.13
> patches manually and then done an hg pull and got the new patch in the
> patches directory but failed to apply it to your kernel?
I used linux-2.6.16.20.tar.bz2 from kernel.org, and patched it with mkbuildtree
from xen-unstable.hg .

Can mkbuildtree automatically patch the kernel?

Johnny
> 
> Harry
> 
> On Tue, 2006-06-13 at 15:05 +0200, Hans-Christian Armingeon wrote:
> > Hi,
> > 
> > kernel building doesn''t work witth current hg unstable tree
and 2.6.16.20 on x86:
> > 
> >   GEN     .version
> >   CHK     include/linux/compile.h
> >   UPD     include/linux/compile.h
> >   CC      init/version.o
> >   LD      init/built-in.o
> >   LD      .tmp_vmlinux1
> > arch/i386/kernel/built-in.o: In function `safe_halt'':
undefined reference to `rcu_needs_cpu''
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make[1]: Leaving directory
`/usr/src/xen/build/kernelbau-20060613.3-xen-unstable.hg-nosmp/linux-2.6.16.20-20060613.3-xen-unstable.hg-nosmp-xen''
> > make: *** [stamp-build] Error 2
> > 
> > 
> > Johnny
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> > 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Am Donnerstag, 15. Juni 2006 12:26 schrieben Sie:
> I was worried that I had broken a standard part of the xen build process
> when I submitted my patch but I think you are doing something that is
> not supported.
> 
> The long-term solution to your problem is clearly to complete the
> upstream merge of the xen patches with mainstream Linux.
> 
> There are some issues with making it easier for people to try to use
> non-default kernels.  It''s going to make recreating bugs harder
and
> may cause some spurious problems when patches apply cleanly but are
> incompatible with the chosen kernel.
So using the latest 2.6.16.x kernel isnt actually supported?

Or is that supported, but using a 2.6.17.x kernel wouldn''t be
supported?

Johnny
> 
> Harry.
> 
> On Thu, 2006-06-15 at 11:47 +0200, Hans-Christian Armingeon wrote:
> > Hi Harry,
> > 
> > I wanted mkbuildtree to automatically pick the patches, that are
needed. Some of the 2.6.16.13 patches seem to be already in the mainline kernel
tree.
> > 
> > I can cleanly apply rcu_needs_cpu_patch to 2.6.16.20.
> > 
> > Johnny
> > 
> > Am Mittwoch, 14. Juni 2006 12:55 schrieben Sie:
> > > There''s a patch in patches/linux-2.6.16.13 called
rcu_needs_cpu.patch
> > > which provides rcu_needs_cpu for the 2.6.16.13 kernel which is
the one I
> > > tested against when I submitted the rcu_needs_cpu_patch.
> > > 
> > > I''m not sure how you are getting the 2.6.16.20 kernel. 
If this is a
> > > standard part of the xen-unstable build that is supposed to work
then
> > > let me know how to invoke it and I will fix up the problem.
> > > 
> > > But maybe you have pulled 2.6.16.20 manually, applied the
2.6.16.13
> > > patches manually and then done an hg pull and got the new patch
in the
> > > patches directory but failed to apply it to your kernel?
> > > 
> > > Harry
> > 
> 
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Thu, 2006-06-15 at 13:10 +0200, Hans-Christian Armingeon
wrote:
> Am Donnerstag, 15. Juni 2006 12:26 schrieben Sie:
> > I was worried that I had broken a standard part of the xen build
process
> > when I submitted my patch but I think you are doing something that is
> > not supported.
> > 
> > The long-term solution to your problem is clearly to complete the
> > upstream merge of the xen patches with mainstream Linux.
> > 
> > There are some issues with making it easier for people to try to use
> > non-default kernels.  It''s going to make recreating bugs
harder and
> > may cause some spurious problems when patches apply cleanly but are
> > incompatible with the chosen kernel.
> 
> So using the latest 2.6.16.x kernel isnt actually supported?
I''m a bit out of my depth with the xen build process here and perhaps
someone will correct me but AFAIK, the standard build process in the
xen-unstable tree will currently just build 2.6.16.13 and it is a manual
process for someone to make the change in the unstable tree to move
forwards to a later Linux snapshot.

This should make sense to you if you think that the code in the sparse
tree and the patches in the patches directory all have to be consistent
with the version of Linux chosen and changes to Linux are outside the
control of the Xen developers. So any future version of Linux may
require changes in the sparse tree and the patches directory before it
will work correctly.

Perhaps someone who knows more would like to comment on support for
Linux point releases.
> 
> Or is that supported, but using a 2.6.17.x kernel wouldn''t be
supported?
> 
> Johnny
> 
> > 
> > Harry.
> > 
> > On Thu, 2006-06-15 at 11:47 +0200, Hans-Christian Armingeon wrote:
> > > Hi Harry,
> > > 
> > > I wanted mkbuildtree to automatically pick the patches, that are
needed. Some of the 2.6.16.13 patches seem to be already in the mainline kernel
tree.
> > > 
> > > I can cleanly apply rcu_needs_cpu_patch to 2.6.16.20.
> > > 
> > > Johnny
> > > 
> > > Am Mittwoch, 14. Juni 2006 12:55 schrieben Sie:
> > > > There''s a patch in patches/linux-2.6.16.13 called
rcu_needs_cpu.patch
> > > > which provides rcu_needs_cpu for the 2.6.16.13 kernel which
is the one I
> > > > tested against when I submitted the rcu_needs_cpu_patch.
> > > > 
> > > > I''m not sure how you are getting the 2.6.16.20
kernel.  If this is a
> > > > standard part of the xen-unstable build that is supposed to
work then
> > > > let me know how to invoke it and I will fix up the problem.
> > > > 
> > > > But maybe you have pulled 2.6.16.20 manually, applied the
2.6.16.13
> > > > patches manually and then done an hg pull and got the new
patch in the
> > > > patches directory but failed to apply it to your kernel?
> > > > 
> > > > Harry
> > > 
> > 
> > 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> I''m a bit out of my depth with the xen build process here and
perhaps
> someone will correct me but AFAIK, the standard build process in the
> xen-unstable tree will currently just build 2.6.16.13 and it is a manual
> process for someone to make the change in the unstable tree to move
> forwards to a later Linux snapshot.
Yep.
> This should make sense to you if you think that the code in the sparse
> tree and the patches in the patches directory all have to be consistent
> with the version of Linux chosen and changes to Linux are outside the
> control of the Xen developers. So any future version of Linux may
> require changes in the sparse tree and the patches directory before it
> will work correctly.
Yep yep.
> Perhaps someone who knows more would like to comment on support for
> Linux point releases.
The 2.6.x.y releases generally have small changes moving from y -> y+1.  As a
result it''s often possible to stick the appropriate patch in the
patches/
directory (or apply it directly to the build tree and rebuild) and have it 
work.

There are only a few places in generic code where there could be conflicts, 
and often the stable series patches don''t touch the arch-specific code
at
all.

Strictly you should check through the patch and look for conflicts with 
Xen-related stuff.  However, often (maybe even usually) it''ll work,
it''s just
not officially supported.

Cheers,
Mark
> > Or is that supported, but using a 2.6.17.x kernel wouldn''t be
supported?
> >
> > Johnny
> >
> > > Harry.
> > >
> > > On Thu, 2006-06-15 at 11:47 +0200, Hans-Christian Armingeon
wrote:
> > > > Hi Harry,
> > > >
> > > > I wanted mkbuildtree to automatically pick the patches, that
are
> > > > needed. Some of the 2.6.16.13 patches seem to be already in
the
> > > > mainline kernel tree.
> > > >
> > > > I can cleanly apply rcu_needs_cpu_patch to 2.6.16.20.
> > > >
> > > > Johnny
> > > >
> > > > Am Mittwoch, 14. Juni 2006 12:55 schrieben Sie:
> > > > > There''s a patch in patches/linux-2.6.16.13
called
> > > > > rcu_needs_cpu.patch which provides rcu_needs_cpu for
the 2.6.16.13
> > > > > kernel which is the one I tested against when I
submitted the
> > > > > rcu_needs_cpu_patch.
> > > > >
> > > > > I''m not sure how you are getting the 2.6.16.20
kernel.  If this is
> > > > > a standard part of the xen-unstable build that is
supposed to work
> > > > > then let me know how to invoke it and I will fix up the
problem.
> > > > >
> > > > > But maybe you have pulled 2.6.16.20 manually, applied
the 2.6.16.13
> > > > > patches manually and then done an hg pull and got the
new patch in
> > > > > the patches directory but failed to apply it to your
kernel?
> > > > >
> > > > > Harry
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel