Harry Butterworth
2006-Jun-12 17:41 UTC
[Xen-devel] [PATCH] add multiline flag to regular expression search expressions in block integrity tests
The 02_block_device_write_verify.py test that I wrote is failing because the regular expression to extract the md5sum is only looking at the first line of output and the sum is in a subsequent line (after the output from dd). This patch fixes the test by adding the multiline flag to the search parameters so that the search looks in all lines of the output for the md5sum. I added the multiline flag in all searches to make the tests more robust against changes in the output format of the commands used. I''m not exactly sure how this slipped through my testing. I suspect that I forgot to install the new python file after updating the test to use dd and then tested the old version a second time by accident. Either that or it really did work when I tested it and the output format has changed for some reason. I tested this patch against xen-unstable 10326 and the 02 test fails without the patch and succeeds with it. Thanks to James Dykman for some help with this. Signed-off-by Harry Butterworth <butterwo@uk.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel