Sean Dague
2006-May-26 15:42 UTC
[Xen-devel] [PATCH] turn off b44 module on x86_64, it breaks the build
The attached patch turns off the b44 module on x86_64 xen kernel, as it breaks the build. Note, this was applied many moons ago, and reverted again at some point later. -Sean -- Sean Dague IBM Linux Technology Center email: japh@us.ibm.com Open Hypervisor Team alt: sldague@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Sean Dague
2006-May-30 12:23 UTC
[Xen-devel] Re: [PATCH] turn off b44 module on x86_64, it breaks the build
On Fri, May 26, 2006 at 11:42:19AM -0400, Sean Dague wrote:> The attached patch turns off the b44 module on x86_64 xen kernel, as it > breaks the build. > > Note, this was applied many moons ago, and reverted again at some point > later.It would be really good if this patch was applied. Default x84_64 builds of xen break at the moment. This patch (more or less) was originally applied on March 27 as changeset 40c23921e7295650305c4e4db2480756e9b3e10c, but has since been reverted. -Sean -- Sean Dague IBM Linux Technology Center email: japh@us.ibm.com Open Hypervisor Team alt: sldague@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-May-30 12:27 UTC
Re: [Xen-devel] Re: [PATCH] turn off b44 module on x86_64, it breaks the build
On 30 May 2006, at 13:23, Sean Dague wrote:> It would be really good if this patch was applied. Default x84_64 > builds of > xen break at the moment. This patch (more or less) was originally > applied > on March 27 as changeset 40c23921e7295650305c4e4db2480756e9b3e10c, but > has > since been reverted.How does it break the build? We build -xen kernels as part of automatic regression tests and haven''t seen any build failures. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Sean Dague
2006-May-30 14:55 UTC
Re: [Xen-devel] Re: [PATCH] turn off b44 module on x86_64, it breaks the build
On Tue, May 30, 2006 at 01:27:34PM +0100, Keir Fraser wrote:> > On 30 May 2006, at 13:23, Sean Dague wrote: > > >It would be really good if this patch was applied. Default x84_64 > >builds of > >xen break at the moment. This patch (more or less) was originally > >applied > >on March 27 as changeset 40c23921e7295650305c4e4db2480756e9b3e10c, but > >has > >since been reverted. > > How does it break the build? We build -xen kernels as part of automatic > regression tests and haven''t seen any build failures.I get the following out of a ''make install'' from the xen-unstable tree on x86_64: ... INSTALL sound/usb/snd-usb-lib.ko INSTALL sound/usb/usx2y/snd-usb-usx2y.ko if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F System.map -b / -r 2.6.16.13-xen; fi WARNING: //lib/modules/2.6.16.13-xen/kernel/drivers/net/b44.ko needs unknown symbol dma_get_cache_alignment make[3]: *** [_modinst_post] Error 1 make[3]: Leaving directory `/home/sdague/xen-unstable-fresh/linux-2.6.16.13-xen'' make[2]: *** [build] Error 2 make[2]: Leaving directory `/home/sdague/xen-unstable-fresh'' make[1]: *** [linux-2.6-xen-install] Error 2 make[1]: Leaving directory `/home/sdague/xen-unstable-fresh'' make: *** [install-kernels] Error 1 Which thus is a broken build process. Removal of the b44 module, which won''t work anyway given the unresolved symbols, removes this failure on ''make install'', so it runs through clean. -Sean -- Sean Dague IBM Linux Technology Center email: japh@us.ibm.com Open Hypervisor Team alt: sldague@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-May-30 15:25 UTC
Re: [Xen-devel] Re: [PATCH] turn off b44 module on x86_64, it breaks the build
> Removal of the b44 module, which won''t work anyway given the unresolved > symbols, removes this failure on ''make install'', so it runs through clean.Sean, Please let me know whether the attached patch fixes this build breakage for you. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel