Paul Larson
2006-May-23 19:31 UTC
[Xen-devel] [PATCH] 01_enforce_dom0_cpus_basic_pos reset vcpu count on failures.
If 01_enforce_dom0_cpus_basic_pos fails, the vcpu count for dom0 does not get restored causing subsequent boots to come up with only a single vcpu on dom0. 01_enforce_dom0_cpus_basic_pos.py | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) Signed-off-by: Paul Larson <pl@us.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ryan Harper
2006-May-23 19:49 UTC
Re: [Xen-devel] [PATCH] 01_enforce_dom0_cpus_basic_pos reset vcpu count on failures.
* Paul Larson <pl@us.ibm.com> [2006-05-23 14:33]:> If 01_enforce_dom0_cpus_basic_pos fails, the vcpu count for dom0 does not get > restored causing subsequent boots to come up with only a single vcpu on dom0.Though I''ve never seen this mentioned on the list, I thought we wanted to leave the system in the failed state if a test failed? That''s certainly debatable. Thoughts?> - num_online = int(getDomInfo("Domain-0", "VCPUs")) > - if num_online == dom0_online_vcpus: > - break > - time.sleep(1) > + num_online = int(getDomInfo("Domain-0", "VCPUs")) > + if num_online == dom0_online_vcpus: > + break > + time.sleep(1)White-space damage. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Paul Larson
2006-May-23 20:40 UTC
[Xen-devel] [PATCH] (corrected) 01_enforce_dom0_cpus_basic_pos reset vcpu count on failures.
On Tuesday 23 May 2006 14:49, Ryan Harper wrote:> * Paul Larson <pl@us.ibm.com> [2006-05-23 14:33]: > > If 01_enforce_dom0_cpus_basic_pos fails, the vcpu count for dom0 does not > > get restored causing subsequent boots to come up with only a single vcpu > > on dom0. > > Though I''ve never seen this mentioned on the list, I thought we wanted > to leave the system in the failed state if a test failed? That''s > certainly debatable. Thoughts?Generally, that''s probably a good rule but in this case it''s better to go with the FAIL() output and put it back to a reasonable state because the altered state can persist not only out the end of the test run, but across xend restarts and even reboots. The reason this came up is because a bug was filed where a few systems were only showing one cpu in /proc/cpuinfo, but they were configured for smp and had previously booted with all their processors.> White-space damage.Doh! Fixed version attached. 01_enforce_dom0_cpus_basic_pos.py | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) Signed-off-by: Paul Larson <pl@us.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2006-Jun-01 11:12 UTC
Re: [Xen-devel] [PATCH] (corrected) 01_enforce_dom0_cpus_basic_pos reset vcpu count on failures.
On Tue, May 23, 2006 at 03:40:14PM -0500, Paul Larson wrote:> On Tuesday 23 May 2006 14:49, Ryan Harper wrote: > > * Paul Larson <pl@us.ibm.com> [2006-05-23 14:33]: > > > If 01_enforce_dom0_cpus_basic_pos fails, the vcpu count for dom0 does not > > > get restored causing subsequent boots to come up with only a single vcpu > > > on dom0. > > > > Though I''ve never seen this mentioned on the list, I thought we wanted > > to leave the system in the failed state if a test failed? That''s > > certainly debatable. Thoughts? > Generally, that''s probably a good rule but in this case it''s better to go with > the FAIL() output and put it back to a reasonable state because the altered > state can persist not only out the end of the test run, but across xend > restarts and even reboots. The reason this came up is because a bug was > filed where a few systems were only showing one cpu in /proc/cpuinfo, but > they were configured for smp and had previously booted with all their > processors. > > > White-space damage. > Doh! Fixed version attached. > 01_enforce_dom0_cpus_basic_pos.py | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > Signed-off-by: Paul Larson <pl@us.ibm.com>Applied, thank you. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel