Anthony Liguori
2006-May-19 16:16 UTC
[Xen-devel] [PATCH] Expose exception thrown by xen.lowlevel.xc
The attached patch exposes the exception thrown by xen.lowlevel.xc as the type xen.lowlevel.xc.Error which is an exception that inherits from RuntimeError. I only had a few minutes this morning so I didn''t get to xen.lowlevel.xs but hopefully someone else can use this as a guide on what needs to be done. If noone else gets to it, I''ll be able to submit another one in about a week. I''ve only done very basic testing but I don''t expect that this should break anything... Regards, Anthony Liguori _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2006-May-19 16:31 UTC
[Xen-devel] Re: [PATCH] Expose exception thrown by xen.lowlevel.xc
On Fri, May 19, 2006 at 11:16:41AM -0500, Anthony Liguori wrote:> The attached patch exposes the exception thrown by xen.lowlevel.xc as > the type xen.lowlevel.xc.Error which is an exception that inherits from > RuntimeError. > > I only had a few minutes this morning so I didn''t get to xen.lowlevel.xs > but hopefully someone else can use this as a guide on what needs to be > done. If noone else gets to it, I''ll be able to submit another one in > about a week. > > I''ve only done very basic testing but I don''t expect that this should > break anything...Thanks Anthony -- applied. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Anthony Liguori
2006-May-19 16:35 UTC
[Xen-devel] [PATCH] Expose exception thrown by xen.lowlevel.xs (Was Re: [PATCH] Expose exception thrown by xen.lowlevel.xc)
Ewan Mellor wrote:> On Fri, May 19, 2006 at 11:16:41AM -0500, Anthony Liguori wrote: > > >> The attached patch exposes the exception thrown by xen.lowlevel.xc as >> the type xen.lowlevel.xc.Error which is an exception that inherits from >> RuntimeError. >> >> I only had a few minutes this morning so I didn''t get to xen.lowlevel.xs >> but hopefully someone else can use this as a guide on what needs to be >> done. If noone else gets to it, I''ll be able to submit another one in >> about a week. >> >> I''ve only done very basic testing but I don''t expect that this should >> break anything... >> > > Thanks Anthony -- applied. >Got a little more time than I expected to. This one''s quite a bit more invasive but I think it''s needed to at least be consistent with xen.lowlevel.xc. I don''t think we should be tossing an exception with different formats (sometimes we threw a RuntimeError with (errno, msg) and other times just a string--I''ve changed it to always be (errno, msg)). Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> Regards, Anthony Liguori> Ewan. >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kaleb Pederson
2006-May-19 19:44 UTC
Re: [Xen-devel] [PATCH] Expose exception thrown by xen.lowlevel.xs (Was Re: [PATCH] Expose exception thrown by xen.lowlevel.xc)
Thanks Anthony and Ewan! Both the consistency and deriving from RuntimeError will work much better for me -- and many others I''m sure. --Kaleb On 11:35 Fri 19 May , Anthony Liguori wrote:> Got a little more time than I expected to. This one''s quite a bit more > invasive but I think it''s needed to at least be consistent with > xen.lowlevel.xc. I don''t think we should be tossing an exception with > different formats (sometimes we threw a RuntimeError with (errno, msg) > and other times just a string--I''ve changed it to always be (errno, msg)). > > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> > > Regards, > > Anthony Liguori > > >Ewan. > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2006-Jun-01 11:13 UTC
[Xen-devel] Re: [PATCH] Expose exception thrown by xen.lowlevel.xs (Was Re: [PATCH] Expose exception thrown by xen.lowlevel.xc)
On Fri, May 19, 2006 at 11:35:13AM -0500, Anthony Liguori wrote:> Ewan Mellor wrote: > >On Fri, May 19, 2006 at 11:16:41AM -0500, Anthony Liguori wrote: > > > > > >>The attached patch exposes the exception thrown by xen.lowlevel.xc as > >>the type xen.lowlevel.xc.Error which is an exception that inherits from > >>RuntimeError. > >> > >>I only had a few minutes this morning so I didn''t get to xen.lowlevel.xs > >>but hopefully someone else can use this as a guide on what needs to be > >>done. If noone else gets to it, I''ll be able to submit another one in > >>about a week. > >> > >>I''ve only done very basic testing but I don''t expect that this should > >>break anything... > >> > > > >Thanks Anthony -- applied. > > > > Got a little more time than I expected to. This one''s quite a bit more > invasive but I think it''s needed to at least be consistent with > xen.lowlevel.xc. I don''t think we should be tossing an exception with > different formats (sometimes we threw a RuntimeError with (errno, msg) > and other times just a string--I''ve changed it to always be (errno, msg)). > > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>Applied, thank you. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel