mm: PTFILTER_L4 typo
Typo: PTFILTER_l4 should be PTFILTER_L4, as it is the build fails if
CONFIG_PAGING_LEVELS >= 4 is in effect.
Signed-Off-By: Horms <horms@verge.net.au>
xen/arch/x86/mm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- x/xen/arch/x86/mm.c
+++ x/xen/arch/x86/mm.c
@@ -3681,7 +3681,7 @@ int print_page_info (unsigned int pagenr
break;
#if CONFIG_PAGING_LEVELS >= 4
case PGT_l4_page_table:
- ret = PTFILTER_l4;
+ ret = PTFILTER_L4;
type_str = "l4";
break;
#endif
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On 17 May 2006, at 07:29, Horms wrote:> mm: PTFILTER_L4 typo > > Typo: PTFILTER_l4 should be PTFILTER_L4, as it is the build fails if > CONFIG_PAGING_LEVELS >= 4 is in effect. > > Signed-Off-By: Horms <horms@verge.net.au>Hello there. What is PTFILTER_L4? Are you guys implementing something interesting? :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, May 17, 2006 at 01:15:02PM +0100, Keir Fraser wrote:> > On 17 May 2006, at 07:29, Horms wrote: > > >mm: PTFILTER_L4 typo > > > >Typo: PTFILTER_l4 should be PTFILTER_L4, as it is the build fails if > >CONFIG_PAGING_LEVELS >= 4 is in effect. > > > >Signed-Off-By: Horms <horms@verge.net.au> > > Hello there. What is PTFILTER_L4? Are you guys implementing something > interesting? :-)Actually, I have no idea why CONFIG_PAGING_LEVELS ended up being enabled - I was just doing a quick x96_64 build to make sure I hadn''t broken anything there. But it was and I stumbled across this typo. Perhaps the code should be removed if no one is using it. -- Horms http://www.vergenet.net/~horms/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 18 May 2006, at 05:06, Horms wrote:>> Hello there. What is PTFILTER_L4? Are you guys implementing something >> interesting? :-) > > Actually, I have no idea why CONFIG_PAGING_LEVELS ended up being > enabled > - I was just doing a quick x96_64 build to make sure I hadn''t broken > anything there. But it was and I stumbled across this typo. Perhaps the > code should be removed if no one is using it.There is no PTFILTER_L4 in our trees, and never has been. So it must be an addition at your end. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, May 18, 2006 at 08:58:31AM +0100, Keir Fraser wrote:> > On 18 May 2006, at 05:06, Horms wrote: > > >>Hello there. What is PTFILTER_L4? Are you guys implementing something > >>interesting? :-) > > > >Actually, I have no idea why CONFIG_PAGING_LEVELS ended up being > >enabled > >- I was just doing a quick x96_64 build to make sure I hadn''t broken > >anything there. But it was and I stumbled across this typo. Perhaps the > >code should be removed if no one is using it. > > There is no PTFILTER_L4 in our trees, and never has been. So it must be > an addition at your end.Sorry about that, I failed to notice that it was actually in some debugging code I wrote a while back which is still in my tree. Please ignore. -- Horms http://www.vergenet.net/~horms/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel