Xen devel - May 2006 - RE: RE: [Xen-changelog] [MINIOS] Fix the pagefault handler to detect recursive faults.

On 16 May 2006, at 20:01, Petersson, Mats wrote:
> Ok. What confused me is that the defintion of read_cr2 is using
> smp_processor_id(), but I guess it''s just a constant value for
minios
> and the macro is a copy from something else... ;-)
Yes, various little bits and pieces are ripped off from our Linux 
patchset.

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] 
> Sent: 16 May 2006 19:46
> To: Petersson, Mats
> Cc: xen-devel@lists.xensource.com; xen-changelog@lists.xensource.com
> Subject: Re: [Xen-devel] RE: [Xen-changelog] [MINIOS] Fix the 
> pagefault handler to detect recursive faults.
> 
> 
> On 16 May 2006, at 19:47, Petersson, Mats wrote:
> 
> >> +static int handling_pg_fault = 0;
> >
> > Surely this needs to be an array indexed by smp_processor_id(), or 
> > otherwise what happens if CPU0 page-faults when CPU1 is 
> currently in a 
> > page-fault?
> >
> > Or have I missed something that prevents this from ever happening?
> 
> Mini-OS is a uniprocessor guest OS.
Ok. What confused me is that the defintion of read_cr2 is using
smp_processor_id(), but I guess it''s just a constant value for minios
and the macro is a copy from something else... ;-)

--
Mats
> 
>   -- Keir
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel