Pascal Bouchareine
2006-May-15 18:15 UTC
[Xen-devel] [PATCH] blkfront: ioctls/geometry, 2.6
Hi, Adds HDIO_GETGEO, BLKGETSIZE, BLKGETSIZE64 support to blkfront. An attempt to merge in the following sent previously by Ian Pratt : http://lists.xensource.com/archives/html/xen-devel/2005-01/msg00659.html Taking into account the block_device_operations for get_geom. Regards, Pascal -- \o/ Pascal Bouchareine - Gandi g 0170393757 15, place de la Nation - 75011 Paris _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
We did a similar patch recently here (not submitted, yet) - so I immediately see some concerns with your patch: - Why do you need to add BLKGETSIZE and BLKGETSIZE64? block/ioctl.c is already taking care of those, they should never arrive at the driver. - The calculation of the cylinder value seems odd to me. Why don''t you use sector_div() here? - There is an apparently unused variable ''dpart'' left in blkif_getgeo(). Jan>>> Pascal Bouchareine <pascal@gandi.net> 15.05.06 20:15 >>>Hi, Adds HDIO_GETGEO, BLKGETSIZE, BLKGETSIZE64 support to blkfront. An attempt to merge in the following sent previously by Ian Pratt : http://lists.xensource.com/archives/html/xen-devel/2005-01/msg00659.html Taking into account the block_device_operations for get_geom. Regards, Pascal -- \o/ Pascal Bouchareine - Gandi g 0170393757 15, place de la Nation - 75011 Paris _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Pascal Bouchareine
2006-May-16 07:35 UTC
Re: [Xen-devel] [PATCH] blkfront: ioctls/geometry, 2.6
On Tue, May 16, 2006 at 09:18:39AM +0200, Jan Beulich wrote:> We did a similar patch recently here (not submitted, yet) - so I immediately see some concerns with your patch:Thanks for your reply. When do you plan to submit the said patch ? Understood for the 3 cons, I can remove the odd calls if required, just let me know if a modified patch is needed. Regards, Pascal -- \o/ Pascal Bouchareine - Gandi g 0170393757 15, place de la Nation - 75011 Paris _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Attaching our patch. Jan>>> Pascal Bouchareine <pascal@gandi.net> 16.05.06 09:35 >>>On Tue, May 16, 2006 at 09:18:39AM +0200, Jan Beulich wrote:> We did a similar patch recently here (not submitted, yet) - so I immediately see some concerns with your patch:Thanks for your reply. When do you plan to submit the said patch ? Understood for the 3 cons, I can remove the odd calls if required, just let me know if a modified patch is needed. Regards, Pascal -- \o/ Pascal Bouchareine - Gandi g 0170393757 15, place de la Nation - 75011 Paris _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel