Petersson, Mats
2006-May-08 09:36 UTC
RE: [Xen-devel] Fwd: BUG - make uninstall deletes my config files
> -----Original Message----- > From: xen-devel-bounces@lists.xensource.com > [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of > Henning Sprang > Sent: 08 May 2006 10:04 > To: xen-devel@lists.xensource.com > Subject: [Xen-devel] Fwd: BUG - make uninstall deletes my config files > > Hi, > I happily found out these days that the xen sources include > an uninstall make target. > > But the happiness didn''t last too long: > The uninstall target of the xen source distribution does not > only delete any file installed by xen, but it seems to > completely delete /etc/xen, so all my self-created config > files have just been deleted when I used taht target. > > The uninstall target should definitely only delete files it > copied at install time, and try to rmdir /etc/xen, which > fails if a user added own config files.Whilst I completely agree with the above, I still think that the CORRECT solution would be to have a "uninstall script" that is either created by the makefile when the dist is created, or created "at runtime" when the install.sh is run. The main reason this is the "best" approach is that files sometimes move or disappear in new versions, and to correctly uninstall such files, we need to know where they went when they were installed - particularly typical example would be if someone is installing a 64-bit Xen on top of a 32-bit version [or vice versa] - many of the files are now in both /usr/lib and /usr/lib64 [and others similar to it] - and only path-order will give one priority over the other. So, the uninstall should REMOVE the exact files that it created - nothing more and nothing less. I also have separate build and test machine, so I have to keep two copies of the source on the two machines [yes, there are ways to share the files across multiple machines, but that''s not really the issue]. -- Mats> > Henning > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel