Xen devel - May 2006 - Fix XEN_GUEST_HANDLE changes in ia64 build

Looks like this patch (9899?) wasn''t compile-tested on ia64.

===========
Fix ia64 build. do_physdev_op* declared incorrectly
Signed-off-by: Dan Magenheimer <dan.magenheimer@hp.com>

diff -r dc3c59367403 xen/arch/ia64/xen/hypercall.c
--- a/xen/arch/ia64/xen/hypercall.c	Mon May  1 16:44:51 2006
+++ b/xen/arch/ia64/xen/hypercall.c	Mon May  1 14:17:19 2006
@@ -27,8 +27,8 @@
 #include <xen/domain.h>
 
 extern unsigned long translate_domain_mpaddr(unsigned long);
-static long do_physdev_op_compat(int cmd, XEN_GUEST_HANDLE(void) arg);
-static long do_physdev_op(XEN_GUEST_HANDLE(physdev_op_t) uop);
+static long do_physdev_op_compat(XEN_GUEST_HANDLE(physdev_op_t) uop);
+static long do_physdev_op(int cmd, XEN_GUEST_HANDLE(void) arg);
 /* FIXME: where these declarations should be there ? */
 extern int dump_privop_counts_to_user(char *, int);
 extern int zero_privop_counts_to_user(char *, int);

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 1 May 2006, at 22:22, Magenheimer, Dan (HP Labs Fort Collins) wrote:
> Looks like this patch (9899?) wasn''t compile-tested on ia64.
We never compile-test on ia64, but I usually make a best-effort attempt 
to fix up arch/ia64 ''by eye''. It at least eases the ia64
maintainer
job.

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Sorry, no offense intended.  Some of the Xen/ia64 developers
have scripts that check xen-unstable for this daily and I
was surprised that nobody else had caught it yet.

If you could, please apply the patch (from the basenote).

Thanks,
Dan 
> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] 
> Sent: Tuesday, May 02, 2006 2:11 AM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: xen-devel@lists.xensource.com
> Subject: Re: [Xen-devel] Fix XEN_GUEST_HANDLE changes in ia64 build
> 
> 
> On 1 May 2006, at 22:22, Magenheimer, Dan (HP Labs Fort 
> Collins) wrote:
> 
> > Looks like this patch (9899?) wasn''t compile-tested on ia64.
> 
> We never compile-test on ia64, but I usually make a 
> best-effort attempt 
> to fix up arch/ia64 ''by eye''. It at least eases the ia64
maintainer
> job.
> 
>   -- Keir
> 
> 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel