Isaku Yamahata
2006-Apr-28 06:32 UTC
[Xen-devel] [PATCH 1/2] balloon driver: relax BUG_ON() in increasee_reservation()
1 / 2 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Apr-28 06:59 UTC
Re: [Xen-devel] [PATCH 1/2] balloon driver: relax BUG_ON() in increasee_reservation()
x86 phys_to_machine_ampping_valid() includes a check of the autotranslate feature flag. It always returns 1 if that flag is set. -- Keir On 28 Apr 2006, at 07:32, Isaku Yamahata wrote:> > 1 / 2 > <9878: > 9a39580dffc0_balloon_driver_relax_bug_on.patch>________________________ > _______________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2006-Apr-28 07:23 UTC
Re: [Xen-devel] [PATCH 1/2] balloon driver: relax BUG_ON() in increasee_reservation()
On Fri, Apr 28, 2006 at 07:59:04AM +0100, Keir Fraser wrote:> x86 phys_to_machine_ampping_valid() includes a check of the > autotranslate feature flag. It always returns 1 if that flag is set.Yes. So when autotranslate feature flag is set, BUG_ON(phys_to_machine_mapping_valid(pfn)) becomes BUG_ON(1) which results in kernel panic. This means that the balloon driver can''t be used with autotranslate feature flag set. Is this really your intention? -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Apr-28 07:29 UTC
Re: [Xen-devel] [PATCH 1/2] balloon driver: relax BUG_ON() in increasee_reservation()
On 28 Apr 2006, at 08:23, Isaku Yamahata wrote:>> x86 phys_to_machine_ampping_valid() includes a check of the >> autotranslate feature flag. It always returns 1 if that flag is set. > > Yes. So when autotranslate feature flag is set, > BUG_ON(phys_to_machine_mapping_valid(pfn)) becomes BUG_ON(1) > which results in kernel panic. > This means that the balloon driver can''t be used with autotranslate > feature flag set. > Is this really your intention?Oh yes, good point. Actually I guess it''s not clear what phys_to_machine_mapping_valid() shoudl return for auto-translated guests. Possibly it should assert that autotranslate is false. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel