Isaku Yamahata
2006-Apr-28 02:52 UTC
[Xen-devel] [PATCH 2/5] [RESEND] changes of common files for xen/ia64 dom0 vp model: privcmd_mmap
introduce xen_arch_privcmd_mmap() to allow xen/ia64 to override privcmd_mmap() later. xen/ia64 with dom0 vp model also needs direct_remap_pfn_range() to be called for IOCTL_PRIVCMD_MMAPBATCH. These changes are necessary for xen/ia64 with dom0 vp model. -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Apr-28 13:43 UTC
Re: [Xen-devel] [PATCH 2/5] [RESEND] changes of common files for xen/ia64 dom0 vp model: privcmd_mmap
On 28 Apr 2006, at 03:52, Isaku Yamahata wrote:> introduce xen_arch_privcmd_mmap() to allow xen/ia64 to override > privcmd_mmap() > later. > xen/ia64 with dom0 vp model also needs direct_remap_pfn_range() to be > called > for IOCTL_PRIVCMD_MMAPBATCH. > These changes are necessary for xen/ia64 with dom0 vp model.Can you describe the use of xen_arch_privcmd_mmap() for ia64? I checked in the other hunks of this patch, but excluded the xen_arch_privcmd_mmap bits for now -- they can go in a separate patch. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2006-Apr-29 05:51 UTC
Re: [Xen-devel] [PATCH 2/5] [RESEND] changes of common files for xen/ia64 dom0 vp model: privcmd_mmap
On Fri, Apr 28, 2006 at 02:43:58PM +0100, Keir Fraser wrote:> > On 28 Apr 2006, at 03:52, Isaku Yamahata wrote: > > >introduce xen_arch_privcmd_mmap() to allow xen/ia64 to override > >privcmd_mmap() > >later. > >xen/ia64 with dom0 vp model also needs direct_remap_pfn_range() to be > >called > >for IOCTL_PRIVCMD_MMAPBATCH. > >These changes are necessary for xen/ia64 with dom0 vp model. > > Can you describe the use of xen_arch_privcmd_mmap() for ia64? I checked > in the other hunks of this patch, but excluded the > xen_arch_privcmd_mmap bits for now -- they can go in a separate patch.It sets its own vma->vm_ops to track mmap/munmap. When the region is completely unmapped, pages of a foreign domain are zapped from dom0. I attached the patch which implements it. (HYPERVISOR_add_physmap(), HYPERVISOR_zap_physmap() are ia64 specific hypercalls.) It can''t be applied to xen-unstable.hg nor xen-ia64-unstable.hg cleanly because it is one of the series patches which is being merged. The patch will be merged into xen-ia64-unstable.hg in the near future. (At least I hope so) I think it can be simplified using PageForeign() and its families. When I wrote it I did''t want to use PG_foreign bit. -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Apr-29 07:31 UTC
Re: [Xen-devel] [PATCH 2/5] [RESEND] changes of common files for xen/ia64 dom0 vp model: privcmd_mmap
On 29 Apr 2006, at 06:51, Isaku Yamahata wrote:> It sets its own vma->vm_ops to track mmap/munmap. > When the region is completely unmapped, pages of a foreign domain > are zapped from dom0.Okay, please send a patch to implement your required hook into privcmd.c. I''d prefer it to be done by defining HAVE_ARCH_PRIVCMD_MMAP, then we can #ifndef the whole function in privcmd.c. It''s so small that separating arch-specific from generic parts is not worthwhile. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2006-Apr-29 10:13 UTC
Re: [Xen-devel] [PATCH 2/5] [RESEND] changes of common files for xen/ia64 dom0 vp model: privcmd_mmap
On Sat, Apr 29, 2006 at 08:31:59AM +0100, Keir Fraser wrote:> > On 29 Apr 2006, at 06:51, Isaku Yamahata wrote: > > >It sets its own vma->vm_ops to track mmap/munmap. > >When the region is completely unmapped, pages of a foreign domain > >are zapped from dom0. > > Okay, please send a patch to implement your required hook into > privcmd.c. > > I''d prefer it to be done by defining HAVE_ARCH_PRIVCMD_MMAP, then we > can #ifndef the whole function in privcmd.c. It''s so small that > separating arch-specific from generic parts is not worthwhile.Here is the patch. Thank you very much for your patience. -- yamahata _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel