With sles 10, ''make tools'' produces the following: CFLAGS="-O2 -fomit-frame-pointer -DNDEBUG -m32 -march=i686 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -D__XEN_INTERFACE_VERSION__=0x00030101" python setup.py install --home="/root/xen/xen-unstable.hg/dist/install/usr" --force running install error: must supply either home or prefix/exec-prefix -- not both make[2]: *** [install] Error 1 make[2]: Leaving directory `/root/xen/xen-unstable.hg/tools/python'' make[1]: *** [install] Error 2 make[1]: Leaving directory `/root/xen/xen-unstable.hg/tools'' make: *** [install-tools] Error 2 there have been a couple other posts about this: http://lists.xensource.com/archives/html/xen-devel/2006-03/msg00565.html http://lists.xensource.com/archives/html/xen-devel/2006-04/msg00090.html prefix is being passed along for some reason. this patch is a simple fix that will make sure prefix is not defined. Signed-off-by: Ryan Grimm <grimm@us.ibm.com> diff -r 72f9c751d3ea -r 683811163238 tools/pygrub/Makefile --- a/tools/pygrub/Makefile Wed Apr 19 18:32:20 2006 +0100 +++ b/tools/pygrub/Makefile Thu Apr 20 11:27:33 2006 -0500 @@ -11,7 +11,7 @@ build: .PHONY: install ifndef XEN_PYTHON_NATIVE_INSTALL install: all - CFLAGS="$(CFLAGS)" python setup.py install --home="$(DESTDIR)/usr" + CFLAGS="$(CFLAGS)" python setup.py install --home="$(DESTDIR)/usr" --prefix="" else install: all CFLAGS="$(CFLAGS)" python setup.py install --root="$(DESTDIR)" diff -r 72f9c751d3ea -r 683811163238 tools/python/Makefile --- a/tools/python/Makefile Wed Apr 19 18:32:20 2006 +0100 +++ b/tools/python/Makefile Thu Apr 20 11:27:33 2006 -0500 @@ -11,7 +11,7 @@ build: .PHONY: install ifndef XEN_PYTHON_NATIVE_INSTALL install: all - CFLAGS="$(CFLAGS)" python setup.py install --home="$(DESTDIR)/usr" --force + CFLAGS="$(CFLAGS)" python setup.py install --home="$(DESTDIR)/usr" --prefix="" --force else install: all CFLAGS="$(CFLAGS)" python setup.py install --root="$(DESTDIR)" --force -- Thanks, Ryan Grimm IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2006-Apr-21 11:00 UTC
Re: [Xen-devel] [PATCH] fix tools compile issue on sles 10
On Thu, Apr 20, 2006 at 04:42:49PM -0500, Ryan Grimm wrote:> With sles 10, ''make tools'' produces the following: > > CFLAGS="-O2 -fomit-frame-pointer -DNDEBUG -m32 -march=i686 -Wall > -Wstrict-prototypes -Wdeclaration-after-statement > -D__XEN_INTERFACE_VERSION__=0x00030101" python setup.py install > --home="/root/xen/xen-unstable.hg/dist/install/usr" --force > running install > error: must supply either home or prefix/exec-prefix -- not both > make[2]: *** [install] Error 1 > make[2]: Leaving directory `/root/xen/xen-unstable.hg/tools/python'' > make[1]: *** [install] Error 2 > make[1]: Leaving directory `/root/xen/xen-unstable.hg/tools'' > make: *** [install-tools] Error 2 > > there have been a couple other posts about this: > > http://lists.xensource.com/archives/html/xen-devel/2006-03/msg00565.html > http://lists.xensource.com/archives/html/xen-devel/2006-04/msg00090.html > > prefix is being passed along for some reason. this patch is a simple fix > that will make sure prefix is not defined. > > Signed-off-by: Ryan Grimm <grimm@us.ibm.com>I''d rather we understood _where_ this mysterious new parameter is coming from, than just hiding it like this. Anyone got any ideas? Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ryan Grimm
2006-Apr-21 19:43 UTC
Re: [Xen-devel] [PATCH] fix tools compile issue on sles 10
On Fri, Apr 21, 2006 at 12:00:16PM +0100, Ewan Mellor wrote:> On Thu, Apr 20, 2006 at 04:42:49PM -0500, Ryan Grimm wrote: > > > With sles 10, ''make tools'' produces the following: > > > > CFLAGS="-O2 -fomit-frame-pointer -DNDEBUG -m32 -march=i686 -Wall > > -Wstrict-prototypes -Wdeclaration-after-statement > > -D__XEN_INTERFACE_VERSION__=0x00030101" python setup.py install > > --home="/root/xen/xen-unstable.hg/dist/install/usr" --force > > running install > > error: must supply either home or prefix/exec-prefix -- not both > > make[2]: *** [install] Error 1 > > make[2]: Leaving directory `/root/xen/xen-unstable.hg/tools/python'' > > make[1]: *** [install] Error 2 > > make[1]: Leaving directory `/root/xen/xen-unstable.hg/tools'' > > make: *** [install-tools] Error 2 > > > > there have been a couple other posts about this: > > > > http://lists.xensource.com/archives/html/xen-devel/2006-03/msg00565.html > > http://lists.xensource.com/archives/html/xen-devel/2006-04/msg00090.html > > > > prefix is being passed along for some reason. this patch is a simple fix > > that will make sure prefix is not defined. > > > > Signed-off-by: Ryan Grimm <grimm@us.ibm.com> > > I''d rather we understood _where_ this mysterious new parameter is coming from, > than just hiding it like this. Anyone got any ideas? > > Ewan.sles 10 includes a distutils.cfg in /usr/lib/python/distutils/ that defines the following: [install] prefix=/usr/local this can be overridden by including an empty --prefix in the Makefile or including a local setup.cfg in the tools/python directory that defines an empty prefix. since --home is already defined in the makefile, i think it makes sense to override --prefix in the makefile. -- Thanks, Ryan Grimm IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2006-Apr-23 21:41 UTC
Re: [Xen-devel] [PATCH] fix tools compile issue on sles 10
On Fri, Apr 21, 2006 at 02:43:03PM -0500, Ryan Grimm wrote:> On Fri, Apr 21, 2006 at 12:00:16PM +0100, Ewan Mellor wrote: > > On Thu, Apr 20, 2006 at 04:42:49PM -0500, Ryan Grimm wrote: > > > > > With sles 10, ''make tools'' produces the following: > > > > > > CFLAGS="-O2 -fomit-frame-pointer -DNDEBUG -m32 -march=i686 -Wall > > > -Wstrict-prototypes -Wdeclaration-after-statement > > > -D__XEN_INTERFACE_VERSION__=0x00030101" python setup.py install > > > --home="/root/xen/xen-unstable.hg/dist/install/usr" --force > > > running install > > > error: must supply either home or prefix/exec-prefix -- not both > > > make[2]: *** [install] Error 1 > > > make[2]: Leaving directory `/root/xen/xen-unstable.hg/tools/python'' > > > make[1]: *** [install] Error 2 > > > make[1]: Leaving directory `/root/xen/xen-unstable.hg/tools'' > > > make: *** [install-tools] Error 2 > > > > > > there have been a couple other posts about this: > > > > > > http://lists.xensource.com/archives/html/xen-devel/2006-03/msg00565.html > > > http://lists.xensource.com/archives/html/xen-devel/2006-04/msg00090.html > > > > > > prefix is being passed along for some reason. this patch is a simple fix > > > that will make sure prefix is not defined. > > > > > > Signed-off-by: Ryan Grimm <grimm@us.ibm.com> > > > > I''d rather we understood _where_ this mysterious new parameter is coming from, > > than just hiding it like this. Anyone got any ideas? > > > > Ewan. > > sles 10 includes a distutils.cfg in /usr/lib/python/distutils/ that > defines the following: > > [install] > prefix=/usr/local > > this can be overridden by including an empty --prefix in the Makefile or > including a local setup.cfg in the tools/python directory that defines > an empty prefix. since --home is already defined in the makefile, i > think it makes sense to override --prefix in the makefile.Thanks for that Ryan -- that all makes sense, and your patch has gone in. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel