Daniel Stekloff
2006-Apr-19 18:35 UTC
[Xen-devel] [PATCH][XM-TEST] Fix for 15_create_smallmem_pos.py test - Bug 616
Hi, Here''s the first step toward dealing with the small memory issue. The 15_create_smallmem_pos.py test was hanging because it created a 16 MB domain and never got to the point where it could set a console limit. The OOM messages flooded the console on creation and the select in Console.py always had something to read. Since there was no limit and it never timed out, the test would hang. This patch: 1) Adds a new cLimit arg for console limit to XmConsole, so it can be set before the console is created. 2) Adds a default console limit rather than setting it to None. We''d rather hit an exception for a limit than hanging the console in the future. Tests that need more console data can always reset the limit. 3) Changes 15_create_smallmem_pos.py''s 16 MEM to 32 MBs, the default that should work for the tools. 4) Adds a new 16_create_smallmem_neg.py test to hit the lowmem test failure. Thanks, Dan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Daniel Stekloff
2006-Apr-19 19:09 UTC
[Xen-devel] [PATCH][XM-TEST][2/2] Fix for 15_create_smallmem_pos.py test - Bug 616
Hi, I forgot to patch the XmTestDomain''s minSafeMem method, which was returning 16. This should apply after the previous patch. Sorry for the mistake. Dan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ewan Mellor
2006-Apr-19 21:59 UTC
[Xen-devel] Re: [PATCH][XM-TEST] Fix for 15_create_smallmem_pos.py test - Bug 616
On Wed, Apr 19, 2006 at 11:35:21AM -0700, Daniel Stekloff wrote:> > Hi, > > Here''s the first step toward dealing with the small memory issue. The > 15_create_smallmem_pos.py test was hanging because it created a 16 MB > domain and never got to the point where it could set a console limit. > The OOM messages flooded the console on creation and the select in > Console.py always had something to read. Since there was no limit and it > never timed out, the test would hang. > > This patch: > > 1) Adds a new cLimit arg for console limit to XmConsole, so it can be > set before the console is created. > > 2) Adds a default console limit rather than setting it to None. We''d > rather hit an exception for a limit than hanging the console in the > future. Tests that need more console data can always reset the limit. > > 3) Changes 15_create_smallmem_pos.py''s 16 MEM to 32 MBs, the default > that should work for the tools. > > 4) Adds a new 16_create_smallmem_neg.py test to hit the lowmem test > failure.That''s all good stuff Dan, thanks. I''ve applied this, plus the two immediately following. Ewan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel