Xen devel - Apr 2006 - RE: [patch] make cpufreq with speedstep-centrino work underXen

> The attached patch fixes the speedstep-centrino driver, to 
> use the hypervisors MSR''s instead of direct MSR access.
> Without the patch the frequency seems to have changed, but 
> the powerconsumption of the CPU has not.
> Thanks to the patch of Matt T. Yourst found here 
> http://lists.xensource.com/archives/html/xen-devel/2006-03/msg
> 01410.html
> It was easy to fix the centrino driver, too.
> 
> If someone could review the patch and bring it upsream (if 
> it''s ok), it would be very nice.
Why not just update xen''s MSR emulation code to handle this case? The
msr hypercall is pretty much a legacy thing.

Ian 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 17 Apr 2006, at 21:24, Ian Pratt wrote:
>> If someone could review the patch and bring it upsream (if
>> it''s ok), it would be very nice.
>
> Why not just update xen''s MSR emulation code to handle this case?
The
> msr hypercall is pretty much a legacy thing.
Matt Yourst''s most recent patch on the list does exactly that and you 
should base your patch on that.

  -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Ian Pratt wrote:
>>The attached patch fixes the speedstep-centrino driver, to 
>>use the hypervisors MSR''s instead of direct MSR access.
>>Without the patch the frequency seems to have changed, but 
>>the powerconsumption of the CPU has not.
>>Thanks to the patch of Matt T. Yourst found here 
>>http://lists.xensource.com/archives/html/xen-devel/2006-03/msg
>>01410.html
>>It was easy to fix the centrino driver, too.
>>
>>If someone could review the patch and bring it upsream (if 
>>it''s ok), it would be very nice.
>>    
>>
>
>Why not just update xen''s MSR emulation code to handle this case?
The
>msr hypercall is pretty much a legacy thing.
>
>Ian 
>
>
>  
>
Hi Ian,

that sounds even better, no need to change all the other cpufreq drivers ;-)
Unfortunately I don''t know how to fix the MSR emulation code.
Any idea, how much effort it will be, resp. when the fix might be 
available ?

Thanks,
ck

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Keir Fraser wrote:
>
> On 17 Apr 2006, at 21:24, Ian Pratt wrote:
>
>>> If someone could review the patch and bring it upsream (if
>>> it''s ok), it would be very nice.
>>
>>
>> Why not just update xen''s MSR emulation code to handle this
case? The
>> msr hypercall is pretty much a legacy thing.
>
>
> Matt Yourst''s most recent patch on the list does exactly that and
you
> should base your patch on that.
>
>  -- Keir
>
Hi Keir,

Just for completeness: the patch you are talking about is this, right ?
http://lists.xensource.com/archives/html/xen-devel/2006-04/msg00484.html

I''m not that much into it (and new to this list, too). However,
I''ll try
to reproduce this one for speedstep-centrino.

Btw, Is there an IRC channel where the devs are hanging around (if I 
need help) ? I could not find one except ##xen on freenode, which looks 
more user oriented.

cheers,
ck




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tue, Apr 18, 2006 at 12:13:41PM +0200, Christian Krafft wrote:
> Btw, Is there an IRC channel where the devs are hanging around (if I 
> need help) ? I could not find one except ##xen on freenode, which looks 
> more user oriented.
#xen on irc.oftc.net. YMMV.

Cheers,
Muli

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel