I noticed there is an prodigious amount of trailing whitespace in tools/libxc. This patch, a result of running perl -p -i -e ''s/\s+$/\n/g'' tools/libxc/*.[ch] removes it all. You could also run the perl yourself to produce the same effect. There were also a few tabs that had snuck in. I left the headers alone, but fixed the instances in code. As usual, the IA64 code contains some truly bizarre use of whitespace, but I resisted the temptation. The resulting patch is ~140KB, so I''ve gzipped it. It introduces no functional changes, and has been compile-tested on x86_32. Please apply. -- Hollis Blanchard IBM Linux Technology Center Fix whitespace in libxc. Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, Apr 14, 2006 at 03:08:31PM -0500, Hollis Blanchard wrote:> I noticed there is an prodigious amount of trailing whitespace in > tools/libxc. This patch, a result of running > perl -p -i -e ''s/\s+$/\n/g'' tools/libxc/*.[ch] > removes it all. You could also run the perl yourself to produce the same > effect. > > There were also a few tabs that had snuck in. I left the headers alone, > but fixed the instances in code. > > As usual, the IA64 code contains some truly bizarre use of whitespace, > but I resisted the temptation. > > The resulting patch is ~140KB, so I''ve gzipped it. It introduces no > functional changes, and has been compile-tested on x86_32. Pleaseapply. Yes please!!! Could we just run this on the entire Xen and tools trees? Cheers, Muli -- Muli Ben-Yehuda http://www.mulix.org | http://mulix.livejournal.com/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Sat, Apr 15, 2006 at 10:47:53AM +0300, Muli Ben-Yehuda wrote:> > tools/libxc. This patch, a result of running > > perl -p -i -e ''s/\s+$/\n/g'' tools/libxc/*.[ch] > > Could we just run this on the entire Xen and tools trees?No, can''t we wait and do this a file at a time when other changes are made? It is far from critical and it makes merging hell... regards john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Sat, Apr 15, 2006 at 03:30:06PM +0100, John Levon wrote:> On Sat, Apr 15, 2006 at 10:47:53AM +0300, Muli Ben-Yehuda wrote: > > > > tools/libxc. This patch, a result of running > > > perl -p -i -e ''s/\s+$/\n/g'' tools/libxc/*.[ch] > > > > Could we just run this on the entire Xen and tools trees? > > No, can''t we wait and do this a file at a time when other changes are > made? It is far from critical and it makes merging hell...I agree it makes merging hell, but hopefully, it will merging hell once and after that something automatic will enforce it at check-in time the same way akpm does for -mm, and all will be well with the world. The strategy you suggest almost always ends up with people making both changes at once, which makes *reviewing* hell. Cheers, Muli -- Muli Ben-Yehuda http://www.mulix.org | http://mulix.livejournal.com/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel