Hi, small patch to fix memcpy misuses in console.c Tested on ia64 only. Tristan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
While I realize this was done that way before, I''d recommend not storing zeroes when clearing a line, but rather spaces with a proper attribute (which will make the console better cooperate with dom0-s potentially doing non-standard things - especially when debugging I happen to output stuff to the screen without going through printk and the like). Of course, this implies not using memset here. Jan>>> Tristan Gingold <Tristan.Gingold@bull.net> 13.04.06 10:58:04 >>>Hi, small patch to fix memcpy misuses in console.c Tested on ia64 only. Tristan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Le Jeudi 13 Avril 2006 13:53, Jan Beulich a écrit :> While I realize this was done that way before, I''d recommend not storing > zeroes when clearing a line, but rather spaces with a proper attribute > (which will make the console better cooperate with dom0-s potentially doing > non-standard things - especially when debugging I happen to output stuff to > the screen without going through printk and the like). Of course, this > implies not using memset here. JanThen you should also update cls(). I have submitted the patch mostly for replacing memcpy by memmove. Using memcpy for scrolling on ia64 makes garbage. Feel free to improve the situation for creating blank lines! Tristan. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel