Woller, Thomas
2006-Apr-12 22:52 UTC
[Xen-devel] [PATCH][SVM][2/5] add guest regs callback function support
SVM patch to add guest regs callback function support. Applies cleanly to 9622. Please apply. Signed-off-by: Tom Woller <thomas.woller@amd.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2006-Apr-13 10:06 UTC
Re: [Xen-devel] [PATCH][SVM][2/5] add guest regs callback function support
On 12 Apr 2006, at 23:52, Woller, Thomas wrote:> SVM patch to add guest regs callback function support. > > Applies cleanly to 9622. > Please apply. > > Signed-off-by: Tom Woller <thomas.woller@amd.com>Why would you want to do this? If the functions are invoked on another domain then it is guaranteed to be paused, and you can read out of its VMCB without loading the VMCB, right? I think this is one VMX artefact you do not need. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Woller, Thomas
2006-Apr-13 16:05 UTC
RE: [Xen-devel] [PATCH][SVM][2/5] add guest regs callback function support
> Why would you want to do this? If the functions are invoked > on another domain then it is guaranteed to be paused, and you > can read out of its VMCB without loading the VMCB, right? I > think this is one VMX artefact you do not need.Agreed that "Guaranteed to be paused" is a correct statement, we can just access the vmcb directly without any loading, and we do not have to load up the MSR_K8_VM_HSAVE_PA MSR with the host save area phys address in this case. Do not apply patch. There is a small bit of cleanup of unused code in the patch, I''ll send cleanup in separate patch later. Thanks Tom _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel