Li, Xin B
2006-Apr-12 07:54 UTC
[Xen-devel] Unmap shadow vtable when freeing shadow table in free_shadow_pages().
Unmap shadow vtable when freeing shadow table in free_shadow_pages(). Signed-off-by: Xin Li <xin.b.li@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
James Morris
2006-Apr-12 19:42 UTC
Re: [Xen-devel] Unmap shadow vtable when freeing shadow table in free_shadow_pages().
On Wed, 12 Apr 2006, Li, Xin B wrote:> Unmap shadow vtable when freeing shadow table in free_shadow_pages(). > > Signed-off-by: Xin Li <xin.b.li@intel.com> >> + if ( v->arch.shadow_vtable ) > + unmap_domain_page_global(v->arch.shadow_vtable); > + v->arch.shadow_vtable = NULL;Why not: if ( v->arch.shadow_vtable ) { unmap_domain_page_global(v->arch.shadow_vtable); v->arch.shadow_vtable = NULL; } -- James Morris <jmorris@redhat.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Li, Xin B
2006-Apr-12 22:29 UTC
RE: [Xen-devel] Unmap shadow vtable when freeing shadow table in free_shadow_pages().
>> Signed-off-by: Xin Li <xin.b.li@intel.com> >> > >> + if ( v->arch.shadow_vtable ) >> + unmap_domain_page_global(v->arch.shadow_vtable); >> + v->arch.shadow_vtable = NULL; > >Why not: > > if ( v->arch.shadow_vtable ) > { > unmap_domain_page_global(v->arch.shadow_vtable); > v->arch.shadow_vtable = NULL; > } >Yes, this is better :-), thanks -Xin> >-- >James Morris ><jmorris@redhat.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel